Repository navigation
perf(coverage): istanbul to use magic-string+rolldown for instrumentation - #11648
Merged
sheremet-va merged 1 commit intoOct 20, 2026
Merged
Conversation
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
AriPerkkio
commented
Oct 19, 2026
AriPerkkio
commented
Oct 19, 2026
Comment on lines
-108
to
-126
| } else { | ||
| const transformMap = new GenMapping(sourceMap) | ||
|
|
||
| eachMapping(new TraceMap(sourceMap as any), (mapping) => { | ||
| addMapping(transformMap, { | ||
| generated: { line: mapping.generatedLine, column: mapping.generatedColumn }, | ||
| original: { line: mapping.generatedLine, column: mapping.generatedColumn }, | ||
| content: sourceCode, | ||
| name: mapping.name || '', | ||
| source: mapping.source || '', | ||
| }) | ||
| }) | ||
|
|
||
| const encodedMap = toEncodedMap(transformMap) | ||
| delete encodedMap.file | ||
| delete encodedMap.ignoreList | ||
| delete encodedMap.sourceRoot | ||
|
|
||
| this.instrumenter.instrumentSync(sourceCode, id, encodedMap as any) |
Member
Author
There was a problem hiding this comment.
Related to the new combineSourceMaps: false. See:
sheremet-va
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
@vitest/istanbul-*packages to latest majors. This speeds up@vitest/coverage-istanbul's instrumentation 5-10x and lowers memory usage a lot. Also trims dependency graphs by dropping Babel and relying on transitive dependencies. See https://github.com/vitest-dev/istanbuljs/releases/tag/v2.0.0.