Repository navigation
fix: avoid leaking the context expect - #11845
Merged
Merged
Conversation
✅ Deploy Preview for vitest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
hi-ogawa
approved these changes
Nov 4, 2026
hi-ogawa
left a comment
Collaborator
There was a problem hiding this comment.
Nice fix! I was concerned about how this can keep local expect's asymmetric matchers working, then I realized my old comment saying they are already shared through a global singleton lol
vitest/packages/expect/src/jest-extend.ts
Lines 179 to 180 in a0adc01
Thank you!!! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11839
With
isolate: false, a test that readsexpectfrom its context kept its whole file and fixture values alive.createExpectadded the built-in matchers again to each localexpect, andchai.use()keeps every plugin closure.customMatchersandbenchMatchersonly to the globalexpectexpect.extendplugin directly instead of withchai.use(); this also releases the matchers that setup files add for each test file