Skip to content

fix(cache): watch cached files outside the root - #11860

Merged
sheremet-va merged 1 commit into
mainfrom
fix/fs-cache-watch-outside-root
Nov 6, 2026
Merged

sheremet-va merged 1 commit into
mainfrom
fix/fs-cache-watch-outside-root

Conversation

@sheremet-va

Copy link
Copy Markdown
Member

Vite adds a file outside the root to the watcher when it transforms the file. A cache hit skips the transform, so a warm vitest --watch did not rerun tests when that file changed.

Fixes #11584

@netlify

netlify Bot commented Nov 3, 2026

Copy link
Copy Markdown

✅ Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit d520303
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/6aea24ea521bcfaea4c7fa04
😎 Deploy Preview https://deploy-preview-11860--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@flakiness-io

flakiness-io Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Test Results Summary

This comment shows the latest test results for this pull request.

Commit Status Test Results CI Runs
d520303 ✅ Passed 24987 passed · 156 flaky · 854 skipped 25 runs
⚠️ 156 flaky

⚠️ win 10.0.26100 · vmThreads test/unit/test/retry.test.ts:55 › describe object add(1, 1) › returned value not be greater than 2
⚠️ Ubuntu 24.04 · vmThreads test/unit/test/retry.test.ts:55 › describe object add(1, 1) › returned value not be greater than 2
⚠️ Ubuntu 24.04 · threads test/unit/test/retry.test.ts:55 › describe object add(1, 1) › returned value not be greater than 2
⚠️ win 10.0.26100 · forks test/unit/test/retry.test.ts:55 › describe object add(1, 1) › returned value not be greater than 2
⚠️ Ubuntu 24.04 · forks test/unit/test/retry.test.ts:55 › describe object add(1, 1) › returned value not be greater than 2
⚠️ win 10.0.26100 · threads test/unit/test/retry.test.ts:55 › describe object add(1, 1) › returned value not be greater than 2
⚠️ win 10.0.26100 · vmThreads test/unit/test/retry.test.ts:61 › describe object add(1, 1) › returned value not be less than 2
⚠️ Ubuntu 24.04 · forks test/unit/test/retry.test.ts:61 › describe object add(1, 1) › returned value not be less than 2
⚠️ win 10.0.26100 · threads test/unit/test/retry.test.ts:61 › describe object add(1, 1) › returned value not be less than 2
⚠️ Ubuntu 24.04 · vmThreads test/unit/test/retry.test.ts:61 › describe object add(1, 1) › returned value not be less than 2
…and 146 more

View full report

ℹ️ About Flakiness.io in GitHub

Your team has set up Flakiness.io pull request comments. This comment is updated when

  • The first test results arrive for this pull request
  • A later run reports more results for the same commit
  • A new commit is pushed and tested

Flakiness.io rewrites the comment in place, so it always reflects the most recently tested commit.

@sheremet-va
sheremet-va marked this pull request as ready for review November 6, 2026 16:07
@sheremet-va
sheremet-va merged commit 9c044db into main Nov 6, 2026
31 of 32 checks passed
@sheremet-va
sheremet-va deleted the fix/fs-cache-watch-outside-root branch November 6, 2026 16:07
jaymalve added a commit to jaymalve/vitest that referenced this pull request Nov 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Watch mode does not rerun tests when a source file outside root changes and fsModuleCache already holds that file

1 participant