Repository navigation
fix(pool): shutdown disconnected workers even when testTimeout is disabled - #11924
Merged
AriPerkkio merged 1 commit intoNov 9, 2026
Merged
Conversation
testTimeout is disabled
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
AriPerkkio
force-pushed
the
fix/pool-disconnect-handler
branch
from
November 9, 2026 12:38
94b6981 to
9df53e0
Compare
sheremet-va
approved these changes
Nov 9, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #11915 but does not close it.
We already have some logic to exit forks when main process suddenly terminates. The handler below triggers only when test runner finishes running a test and is about to send update to main process.
vitest/packages/vitest/src/runtime/workers/init-forks.ts
Line 29 in f21f224
vitest/packages/vitest/src/runtime/workers/init-forks.ts
Lines 55 to 61 in f21f224
But if user has disabled test timeout and a test case never finishes, runner never sends update to main thread. We'll now listen for
disconnectevent and exit the runner.