Skip to content

fix(pool): shutdown disconnected workers even when testTimeout is disabled - #11924

Merged
AriPerkkio merged 1 commit into
vitest-dev:mainfrom
AriPerkkio:fix/pool-disconnect-handler
Nov 9, 2026
Merged

AriPerkkio merged 1 commit into
vitest-dev:mainfrom
AriPerkkio:fix/pool-disconnect-handler

Conversation

@AriPerkkio

Copy link
Copy Markdown
Member

Related to #11915 but does not close it.

We already have some logic to exit forks when main process suddenly terminates. The handler below triggers only when test runner finishes running a test and is about to send update to main process.

processOn('error', onError)

// Prevent leaving worker in loops where it tries to send message to closed main
// thread, errors, and tries to send the error.
function onError(error: any) {
if (error?.code === 'ERR_IPC_CHANNEL_CLOSED' || error?.code === 'EPIPE') {
processExit(1)
}
}

But if user has disabled test timeout and a test case never finishes, runner never sends update to main thread. We'll now listen for disconnect event and exit the runner.

@AriPerkkio AriPerkkio changed the title fix(pool): shutdown disconnected workers fix(pool): shutdown disconnected workers even when testTimeout is disabled Nov 9, 2026
@netlify

netlify Bot commented Nov 9, 2026

Copy link
Copy Markdown

✅ Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 94b6981
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/6af1aeb5532de17b19adff9b
😎 Deploy Preview https://deploy-preview-11924--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@AriPerkkio
AriPerkkio force-pushed the fix/pool-disconnect-handler branch from 94b6981 to 9df53e0 Compare November 9, 2026 12:38
@AriPerkkio
AriPerkkio merged commit 979118a into vitest-dev:main Nov 9, 2026
28 of 29 checks passed
@AriPerkkio
AriPerkkio deleted the fix/pool-disconnect-handler branch November 9, 2026 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants