Skip to content

fix: match - and . in noExternal wildcards - #11978

Merged
sheremet-va merged 6 commits into
vitest-dev:mainfrom
hi-ogawa:fix/issue-11967
Nov 16, 2026
Merged

sheremet-va merged 6 commits into
vitest-dev:mainfrom
hi-ogawa:fix/issue-11967

Conversation

@hi-ogawa

@hi-ogawa hi-ogawa commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator

Previously, * in a resolve.noExternal wildcard was rewritten to [\w/]+, so it couldn't match - or .. For example, @tanstack/start* didn't inline @tanstack/start-client-core, and the behavior diverged from Vite SSR.

This PR tweaks noExternal processing to fix it. There's still a fundamental difference between Vitest and Vite SSR externalization, but this is a sensible alignment improvement. The docs have been updated to call out some gotchas as well.

Closes vitest-dev#11967

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@netlify

netlify Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a8e394f
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/6afad722ddf220551a0b7f2a
😎 Deploy Preview https://deploy-preview-11978--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@flakiness-io

flakiness-io Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Test Results Summary

This comment shows the latest test results for this pull request.

Commit Status Test Results CI Runs
f815ee5 ✅ Passed 23326 passed · 158 flaky · 829 skipped 24 runs
⚠️ 158 flaky

⚠️ win 10.0.26100 · vmThreads test/unit/test/retry.test.ts:55 › describe object add(1, 1) › returned value not be greater than 2
⚠️ Ubuntu 26.04 · vmThreads test/unit/test/retry.test.ts:55 › describe object add(1, 1) › returned value not be greater than 2
⚠️ Ubuntu 26.04 · threads test/unit/test/retry.test.ts:55 › describe object add(1, 1) › returned value not be greater than 2
⚠️ win 10.0.26100 · forks test/unit/test/retry.test.ts:55 › describe object add(1, 1) › returned value not be greater than 2
⚠️ Ubuntu 26.04 · forks test/unit/test/retry.test.ts:55 › describe object add(1, 1) › returned value not be greater than 2
⚠️ win 10.0.26100 · threads test/unit/test/retry.test.ts:55 › describe object add(1, 1) › returned value not be greater than 2
⚠️ win 10.0.26100 · vmThreads test/unit/test/retry.test.ts:61 › describe object add(1, 1) › returned value not be less than 2
⚠️ Ubuntu 26.04 · forks test/unit/test/retry.test.ts:61 › describe object add(1, 1) › returned value not be less than 2
⚠️ win 10.0.26100 · threads test/unit/test/retry.test.ts:61 › describe object add(1, 1) › returned value not be less than 2
⚠️ Ubuntu 26.04 · vmThreads test/unit/test/retry.test.ts:61 › describe object add(1, 1) › returned value not be less than 2
…and 148 more

View full report

ℹ️ About Flakiness.io in GitHub

Your team has set up Flakiness.io pull request comments. This comment is updated when

  • The first test results arrive for this pull request
  • A later run reports more results for the same commit
  • A new commit is pushed and tested

Flakiness.io rewrites the comment in place, so it always reflects the most recently tested commit.

hi-ogawa and others added 5 commits November 16, 2026 19:11
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@hi-ogawa
hi-ogawa marked this pull request as ready for review November 16, 2026 10:15
@hi-ogawa
hi-ogawa requested a review from sheremet-va November 16, 2026 10:32
@sheremet-va
sheremet-va merged commit efba8cb into vitest-dev:main Nov 16, 2026
49 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wildcard in noExternal does not match a dash in a package name

2 participants