Skip to content

fix(coverage): v8 to ignore more Vite's CJS import helpers - #11981

Merged
hi-ogawa merged 1 commit into
vitest-dev:mainfrom
AriPerkkio:fix/coverage-ignore-more-cjs-helpers
Nov 17, 2026
Merged

hi-ogawa merged 1 commit into
vitest-dev:mainfrom
AriPerkkio:fix/coverage-ignore-more-cjs-helpers

Conversation

@AriPerkkio

Copy link
Copy Markdown
Member

Fixes #11980.

Similar to #11676.

@netlify

netlify Bot commented Nov 16, 2026

Copy link
Copy Markdown

✅ Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 36d7520
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/6afb186970bd92ec6982dc00
😎 Deploy Preview https://deploy-preview-11981--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@flakiness-io

flakiness-io Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Test Results Summary

This comment shows the latest test results for this pull request.

Commit Status Test Results CI Runs
36d7520 ✅ Passed 28393 passed · 237 flaky · 1084 skipped 22 runs
⚠️ 237 flaky

⚠️ Ubuntu 26.04 · vmThreads test/unit/test/retry.test.ts:55 › describe object add(1, 1) › returned value not be greater than 2
⚠️ Ubuntu 26.04 · vmThreads test/unit/test/retry.test.ts:55 › describe object add(1, 1) › returned value not be greater than 2
⚠️ Ubuntu 26.04 · threads test/unit/test/retry.test.ts:55 › describe object add(1, 1) › returned value not be greater than 2
⚠️ win 10.0.26100 · vmThreads test/unit/test/retry.test.ts:55 › describe object add(1, 1) › returned value not be greater than 2
⚠️ Ubuntu 26.04 · forks test/unit/test/retry.test.ts:55 › describe object add(1, 1) › returned value not be greater than 2
⚠️ Ubuntu 26.04 · forks test/unit/test/retry.test.ts:55 › describe object add(1, 1) › returned value not be greater than 2
⚠️ win 10.0.26100 · forks test/unit/test/retry.test.ts:55 › describe object add(1, 1) › returned value not be greater than 2
⚠️ Ubuntu 26.04 · threads test/unit/test/retry.test.ts:55 › describe object add(1, 1) › returned value not be greater than 2
⚠️ win 10.0.26100 · threads test/unit/test/retry.test.ts:55 › describe object add(1, 1) › returned value not be greater than 2
⚠️ Ubuntu 26.04 · vmThreads test/unit/test/retry.test.ts:61 › describe object add(1, 1) › returned value not be less than 2
…and 227 more

View full report

ℹ️ About Flakiness.io in GitHub

Your team has set up Flakiness.io pull request comments. This comment is updated when

  • The first test results arrive for this pull request
  • A later run reports more results for the same commit
  • A new commit is pushed and tested

Flakiness.io rewrites the comment in place, so it always reflects the most recently tested commit.

@hi-ogawa
hi-ogawa merged commit 4e905a1 into vitest-dev:main Nov 17, 2026
32 checks passed
@james-gough-op

Copy link
Copy Markdown

@AriPerkkio

Thanks for fixing this so quickly! I’d hoped to contribute the fix myself, which is why I mentioned in the issue that I intended to open a PR after triage approval. I was looking forward to getting a contribution in 🙂

For future reports, is there a better way to signal that I’d like to take on the implementation? Happy to follow whatever process works best for the team.

@AriPerkkio

Copy link
Copy Markdown
Member Author

which is why I mentioned in the issue that I intended to open a PR after triage approval

Oh sorry I completely missed that from the issue. I should have marked your account as approved instead of opening PR myself directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

coverage-v8 counts Vite's negated CJS default-import helper as a source branch

3 participants