Skip to content

[Misc][Docs] fix the comments of KV_T and CACHE_T in CALL_RESHAPE_AND_CACHE_XX macros - #14347

Merged
vllm-bot merged 1 commit into
vllm-project:mainfrom
yangsijia-celina:main
Mar 18, 2025
Merged

vllm-bot merged 1 commit into
vllm-project:mainfrom
yangsijia-celina:main

Conversation

@yangsijia-celina

@yangsijia-celina yangsijia-celina commented Mar 6, 2025 •

Copy link
Copy Markdown
Contributor

Perhaps I misunderstood something, but I currently think that the comments of KV_T and CACHE_T in the CALL_RESHAPE_AND_CACHE_XX macros are swapped.
If my understanding is correct, this PR will fix them.

Please help to review~ Thanks! cc @comaniac @Yard1 @LucasWilkinson

@yangsijia-celina yangsijia-celina changed the title [Misc][Docs] fix the explanation of KV_T and CACHE_T in CALL_RESHAPE_AND_CACHE_XX macros [Misc][Docs] fix the comments of KV_T and CACHE_T in CALL_RESHAPE_AND_CACHE_XX macros Mar 6, 2025
@github-actions

github-actions Bot commented Mar 6, 2025

Copy link
Copy Markdown

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@yangsijia-celina

Copy link
Copy Markdown
Contributor Author

Hi @LucasWilkinson, just a gentle ping on this.
If I misunderstood anything, please feel free to point it out and close this PR. Thank you!

@LucasWilkinson LucasWilkinson left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, you just need to fix the DCO (i.e. signoff on the commits)

@LucasWilkinson
LucasWilkinson enabled auto-merge (squash) March 17, 2025 23:44
@github-actions github-actions Bot added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 17, 2025
@comaniac

Copy link
Copy Markdown
Contributor

DCO is not a merge blocker, but the failed tests are.
We should be able to force merge this PR given it only changes the comments.

@vllm-bot
vllm-bot merged commit 64fc219 into vllm-project:main Mar 18, 2025
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
…_CACHE_XX macros (vllm-project#14347)

Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
…_CACHE_XX macros (vllm-project#14347)

Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
0826joyce pushed a commit to 0826joyce/vllm-serving-optimization that referenced this pull request May 19, 2026
philippesic pushed a commit to philippesic/vllm-semantic-cache that referenced this pull request Jul 19, 2026
plasticchris pushed a commit to plasticchris/vllm that referenced this pull request Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants