Repository navigation
[Misc][Docs] fix the comments of KV_T and CACHE_T in CALL_RESHAPE_AND_CACHE_XX macros - #14347
Conversation
…AND_CACHE_XX macros
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
|
Hi @LucasWilkinson, just a gentle ping on this. |
|
DCO is not a merge blocker, but the failed tests are. |
…_CACHE_XX macros (vllm-project#14347) Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
…_CACHE_XX macros (vllm-project#14347) Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
Perhaps I misunderstood something, but I currently think that the comments of KV_T and CACHE_T in the CALL_RESHAPE_AND_CACHE_XX macros are swapped.
If my understanding is correct, this PR will fix them.
Please help to review~ Thanks! cc @comaniac @Yard1 @LucasWilkinson