Skip to content

[Doc][V1] Fix V1 APC doc - #14920

Merged
comaniac merged 2 commits into
vllm-project:mainfrom
shen-shanshan:doc
Mar 18, 2025
Merged

comaniac merged 2 commits into
vllm-project:mainfrom
shen-shanshan:doc

Conversation

@shen-shanshan

@shen-shanshan shen-shanshan commented Mar 17, 2025 •

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Shanshan Shen <87969357+shen-shanshan@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify Bot added the documentation Improvements or additions to documentation label Mar 17, 2025
@DarkLight1337
DarkLight1337 requested a review from comaniac March 17, 2025 06:30
@comaniac comaniac self-assigned this Mar 17, 2025

@comaniac comaniac left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the example again and listed all typos. Probably because I updated the figures but didn't update the text when polishing the design doc. Please help fix all of them in this PR. Thanks!

Time 1: The cache is empty and a new request comes in. We allocate 4 blocks. 3 of them are already full and cached. The fourth block is partially full with 3 of 4 tokens.

Time 4: Request 1 comes in with the 14 prompt tokens, where the first 10 tokens are the same as request 0. We can see that only the first 2 blocks (8 tokens) hit the cache, because the 3rd block only matches 2 of 4 tokens.

@shen-shanshan

Copy link
Copy Markdown
Contributor Author

I checked the example again and listed all typos. Probably because I updated the figures but didn't update the text when polishing the design doc. Please help fix all of them in this PR. Thanks!

Time 1: The cache is empty and a new request comes in. We allocate 4 blocks. 3 of them are already full and cached. The fourth block is partially full with 3 of 4 tokens.

Time 4: Request 1 comes in with the 14 prompt tokens, where the first 10 tokens are the same as request 0. We can see that only the first 2 blocks (8 tokens) hit the cache, because the 3rd block only matches 2 of 4 tokens.

OK, I will modify it soon.

Signed-off-by: Shanshan Shen <87969357+shen-shanshan@users.noreply.github.com>

@comaniac comaniac left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@comaniac comaniac added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 18, 2025
@comaniac
comaniac enabled auto-merge (squash) March 18, 2025 07:35
@comaniac
comaniac merged commit d169575 into vllm-project:main Mar 18, 2025
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
0826joyce pushed a commit to 0826joyce/vllm-serving-optimization that referenced this pull request May 19, 2026
philippesic pushed a commit to philippesic/vllm-semantic-cache that referenced this pull request Jul 19, 2026
plasticchris pushed a commit to plasticchris/vllm that referenced this pull request Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants