Skip to content

[Misc][V1] Skip device checking if not available - #15061

Merged
vllm-bot merged 2 commits into
vllm-project:mainfrom
comaniac:fix-platform
Mar 19, 2025
Merged

vllm-bot merged 2 commits into
vllm-project:mainfrom
comaniac:fix-platform

Conversation

@comaniac

@comaniac comaniac commented Mar 18, 2025 •

Copy link
Copy Markdown
Contributor

When importing vLLM on a CUDA platform without available GPUs, get_device_capability() returns None, so .get_device_capability().major will raise AttributeError. This happens when integrating vLLM with Ray, because GPUs won't be allocated to the driver process (CUDA_VISIBLE_DEVICES is set to an empty string).

cc @robertgshaw2-redhat

Signed-off-by: Cody Yu <hao.yu.cody@gmail.com>
@comaniac comaniac added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 18, 2025
@github-actions

Copy link
Copy Markdown

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@robertgshaw2-redhat
robertgshaw2-redhat enabled auto-merge (squash) March 18, 2025 21:50
Comment thread vllm/engine/arg_utils.py Resolved
Signed-off-by: Cody Yu <hao.yu.cody@gmail.com>
@vllm-bot
vllm-bot merged commit 4f065f1 into vllm-project:main Mar 19, 2025
@comaniac
comaniac deleted the fix-platform branch March 19, 2025 17:53
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
Signed-off-by: Cody Yu <hao.yu.cody@gmail.com>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
Signed-off-by: Cody Yu <hao.yu.cody@gmail.com>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
Signed-off-by: Cody Yu <hao.yu.cody@gmail.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
0826joyce pushed a commit to 0826joyce/vllm-serving-optimization that referenced this pull request May 19, 2026
Signed-off-by: Cody Yu <hao.yu.cody@gmail.com>
philippesic pushed a commit to philippesic/vllm-semantic-cache that referenced this pull request Jul 19, 2026
Signed-off-by: Cody Yu <hao.yu.cody@gmail.com>
plasticchris pushed a commit to plasticchris/vllm that referenced this pull request Jul 20, 2026
Signed-off-by: Cody Yu <hao.yu.cody@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants