Skip to content

[Build] Fixes for CMake install - #18570

Merged
mgoin merged 1 commit into
vllm-project:mainfrom
neuralmagic:luka/cmake-install-fix
May 28, 2025
Merged

[Build] Fixes for CMake install#18570
mgoin merged 1 commit into
vllm-project:mainfrom
neuralmagic:luka/cmake-install-fix

Conversation

@ProExpertProg

@ProExpertProg ProExpertProg commented May 22, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

This fixes the CMake install logic such that using cmake --install directly is supported. Necessary to fix CMake-based user workflows.

It also fixes the error on ROCm if CMake is used outside the venv (common for IDE-run CMake).

@github-actions

github-actions Bot commented May 22, 2025

Copy link
Copy Markdown

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@ProExpertProg ProExpertProg changed the title Fixes for CMake install [Build] Fixes for CMake install May 22, 2025
@mergify mergify Bot added the ci/build label May 22, 2025
@ProExpertProg
Fixes for CMake install
f6483ae 
Signed-off-by: luka <luka@neuralmagic.com>
@ProExpertProg
ProExpertProg force-pushed the luka/cmake-install-fix branch from 9a6959c to f6483ae Compare May 22, 2025 21:02
LucasWilkinson
LucasWilkinson reviewed May 22, 2025
View reviewed changes

@LucasWilkinson LucasWilkinson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just checking python setup.py build_ext --inplace is not broken by this right?

@ProExpertProg

ProExpertProg commented May 22, 2025

Copy link
Copy Markdown
Contributor Author

just checking python setup.py build_ext --inplace is not broken by this right?

I tried pip install, but let me try a fresh python setup.py build_ext --inplace as well

@LucasWilkinson

LucasWilkinson commented May 22, 2025

Copy link
Copy Markdown
Contributor

just checking python setup.py build_ext --inplace is not broken by this right?

I tried pip install, but let me try a fresh python setup.py build_ext --inplace as well

Please test fresh and incremental

@ProExpertProg

ProExpertProg commented May 22, 2025

Copy link
Copy Markdown
Contributor Author

Yep, tested all three :)

LucasWilkinson
LucasWilkinson approved these changes May 23, 2025
View reviewed changes

@LucasWilkinson LucasWilkinson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, will hold off till after the v0.9.0 release though to avoid anymore cmake thrash (bit of a battle recently haha)

@LucasWilkinson LucasWilkinson added the ready ONLY add when PR is ready to merge/full CI is needed label May 27, 2025
mgoin
mgoin approved these changes May 27, 2025
View reviewed changes

@mgoin mgoin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these "cmake user workflows" actually documented somewhere?

@ProExpertProg

ProExpertProg commented May 27, 2025

Copy link
Copy Markdown
Contributor Author

Are these "cmake user workflows" actually documented somewhere?

No but they should be, I can try to add something.

@mgoin
mgoin merged commit a3896c7 into vllm-project:main May 28, 2025
@ProExpertProg
ProExpertProg deleted the luka/cmake-install-fix branch May 28, 2025 16:05
amitm02 pushed a commit to amitm02/vllm that referenced this pull request Jun 1, 2025
@ProExpertProg @amitm02
[Build] Fixes for CMake install (vllm-project#18570)
b19f788 
Signed-off-by: amit <amit.man@gmail.com>
0826joyce pushed a commit to 0826joyce/vllm-serving-optimization that referenced this pull request May 19, 2026
@ProExpertProg
[Build] Fixes for CMake install (vllm-project#18570)
bb81216
philippesic pushed a commit to philippesic/vllm-semantic-cache that referenced this pull request Jul 19, 2026
@ProExpertProg
[Build] Fixes for CMake install (vllm-project#18570)
f07d022
plasticchris pushed a commit to plasticchris/vllm that referenced this pull request Jul 20, 2026
@ProExpertProg
[Build] Fixes for CMake install (vllm-project#18570)
b77d809
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgoin mgoin mgoin approved these changes
@LucasWilkinson LucasWilkinson LucasWilkinson approved these changes
@tlrmchlsmth tlrmchlsmth Awaiting requested review from tlrmchlsmth tlrmchlsmth is a code owner

Assignees

No one assigned

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ProExpertProg @LucasWilkinson @mgoin