Skip to content

fix security issue of logging llm output - #18980

Merged
DarkLight1337 merged 1 commit into
vllm-project:mainfrom
luccafong:export-D75721539
May 31, 2025
Merged

fix security issue of logging llm output#18980
DarkLight1337 merged 1 commit into
vllm-project:mainfrom
luccafong:export-D75721539

Conversation

@luccafong

@luccafong luccafong commented May 31, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

We should avoid logging output which may leak sensitive information from users to the llm engine service providers.

Differential Revision: D75721539

@github-actions

github-actions Bot commented May 31, 2025

Copy link
Copy Markdown

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@facebook-github-bot

facebook-github-bot commented May 31, 2025

Copy link
Copy Markdown

This pull request was exported from Phabricator. Differential Revision: D75721539

@luccafong luccafong changed the title fix vulnerable issues fix security issue of logging llm output May 31, 2025
Lucia (Lu) Fang @luccafong
fix vulnerable issues
918a146 
Summary: small fix

Differential Revision: D75721539

Signed-off-by: Lu Fang <fanglu@fb.com>
houseroad
houseroad approved these changes May 31, 2025
View reviewed changes

@houseroad houseroad left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@DarkLight1337

DarkLight1337 commented May 31, 2025

Copy link
Copy Markdown
Member

cc @russellb

@DarkLight1337
DarkLight1337 enabled auto-merge (squash) May 31, 2025 06:23
@github-actions github-actions Bot added the ready ONLY add when PR is ready to merge/full CI is needed label May 31, 2025
@DarkLight1337
DarkLight1337 merged commit b8b9047 into vllm-project:main May 31, 2025
amitm02 pushed a commit to amitm02/vllm that referenced this pull request Jun 1, 2025
@luccafong Lucia (Lu) Fang @amitm02
fix security issue of logging llm output (vllm-project#18980)
7b0cc99 
Signed-off-by: Lu Fang <fanglu@fb.com>
Co-authored-by: Lucia (Lu) Fang <fanglu@meta.com>
Signed-off-by: amit <amit.man@gmail.com>
amitm02 pushed a commit to amitm02/vllm that referenced this pull request Jun 1, 2025
@luccafong Lucia (Lu) Fang @amitm02
fix security issue of logging llm output (vllm-project#18980)
1f73477 
Signed-off-by: Lu Fang <fanglu@fb.com>
Co-authored-by: Lucia (Lu) Fang <fanglu@meta.com>
Signed-off-by: amit <amit.man@gmail.com>
0826joyce pushed a commit to 0826joyce/vllm-serving-optimization that referenced this pull request May 19, 2026
@luccafong Lucia (Lu) Fang
fix security issue of logging llm output (vllm-project#18980)
3841f1d 
Signed-off-by: Lu Fang <fanglu@fb.com>
Co-authored-by: Lucia (Lu) Fang <fanglu@meta.com>
philippesic pushed a commit to philippesic/vllm-semantic-cache that referenced this pull request Jul 19, 2026
@luccafong Lucia (Lu) Fang
fix security issue of logging llm output (vllm-project#18980)
6c036ab 
Signed-off-by: Lu Fang <fanglu@fb.com>
Co-authored-by: Lucia (Lu) Fang <fanglu@meta.com>
plasticchris pushed a commit to plasticchris/vllm that referenced this pull request Jul 20, 2026
@luccafong Lucia (Lu) Fang
fix security issue of logging llm output (vllm-project#18980)
f5b2ea0 
Signed-off-by: Lu Fang <fanglu@fb.com>
Co-authored-by: Lucia (Lu) Fang <fanglu@meta.com>
@arpera arpera removed this from Tool Calling Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@houseroad houseroad houseroad approved these changes
@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees

No one assigned

Labels

frontend ready ONLY add when PR is ready to merge/full CI is needed tool-calling

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@luccafong @facebook-github-bot @DarkLight1337 @houseroad