Skip to content

[BugFix] Fix incorrect metrics shutdown error log message - #18992

Merged
DarkLight1337 merged 1 commit into
vllm-project:mainfrom
njhill:fix-mp-prom-warning
Jun 1, 2025
Merged

DarkLight1337 merged 1 commit into
vllm-project:mainfrom
njhill:fix-mp-prom-warning

Conversation

@njhill

@njhill njhill commented May 31, 2025 •

Copy link
Copy Markdown
Member

Introduced in #17546. We should only call mark_process_dead when we're using prometheus multiprocessing mode (with > 1 API servers).

ERROR 05-31 01:04:14 [prometheus.py:77] Error during metrics cleanup: expected str, bytes or os.PathLike object, not NoneType

Thanks to @lgeiger for reporting.

Introduced in vllm-project#17546. We should only call mark_process_dead when we're using prometheus multiprocessing mode (with > 1 API servers).

Signed-off-by: Nick Hill <nhill@redhat.com>
@github-actions

Copy link
Copy Markdown

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify Bot added the v1 label May 31, 2025
@njhill njhill added the ready ONLY add when PR is ready to merge/full CI is needed label May 31, 2025

@houseroad houseroad left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@DarkLight1337
DarkLight1337 merged commit 2b102d5 into vllm-project:main Jun 1, 2025
amitm02 pushed a commit to amitm02/vllm that referenced this pull request Jun 1, 2025
…ct#18992)

Signed-off-by: Nick Hill <nhill@redhat.com>
Signed-off-by: amit <amit.man@gmail.com>
amitm02 pushed a commit to amitm02/vllm that referenced this pull request Jun 1, 2025
…ct#18992)

Signed-off-by: Nick Hill <nhill@redhat.com>
Signed-off-by: amit <amit.man@gmail.com>
@njhill
njhill deleted the fix-mp-prom-warning branch June 2, 2025 14:48
0826joyce pushed a commit to 0826joyce/vllm-serving-optimization that referenced this pull request May 19, 2026
philippesic pushed a commit to philippesic/vllm-semantic-cache that referenced this pull request Jul 19, 2026
plasticchris pushed a commit to plasticchris/vllm that referenced this pull request Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants