Repository navigation
[BugFix] Fix incorrect metrics shutdown error log message - #18992
Conversation
Introduced in vllm-project#17546. We should only call mark_process_dead when we're using prometheus multiprocessing mode (with > 1 API servers). Signed-off-by: Nick Hill <nhill@redhat.com>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
…ct#18992) Signed-off-by: Nick Hill <nhill@redhat.com> Signed-off-by: amit <amit.man@gmail.com>
…ct#18992) Signed-off-by: Nick Hill <nhill@redhat.com> Signed-off-by: amit <amit.man@gmail.com>
…ct#18992) Signed-off-by: Nick Hill <nhill@redhat.com>
…ct#18992) Signed-off-by: Nick Hill <nhill@redhat.com>
…ct#18992) Signed-off-by: Nick Hill <nhill@redhat.com>
Introduced in #17546. We should only call mark_process_dead when we're using prometheus multiprocessing mode (with > 1 API servers).
Thanks to @lgeiger for reporting.