Repository navigation
feat(cache): treat files and folders renamed into place as outputs - #916
Merged
wan9chi merged 2 commits intoNov 5, 2026
Merged
Conversation
wan9chi
force-pushed
the
feat/cache-rename-targets
branch
from
October 30, 2026 03:19
430963c to
b139ee7
Compare
fspy benchmarklinuxmacoswindows |
wan9chi
force-pushed
the
feat/cache-rename-targets
branch
from
October 30, 2026 04:07
b139ee7 to
8a1becb
Compare
wan9chi
force-pushed
the
feat/cache-rename-targets
branch
from
October 30, 2026 06:31
8a1becb to
6af0c77
Compare
wan9chi
force-pushed
the
feat/cache-rename-targets
branch
from
October 30, 2026 07:08
6af0c77 to
a446e8f
Compare
wan9chi
force-pushed
the
feat/cache-rename-targets
branch
from
November 1, 2026 11:55
a446e8f to
67fd287
Compare
wan9chi
force-pushed
the
feat/cache-rename-targets
branch
from
November 5, 2026 08:54
67fd287 to
b3a0de9
Compare
β¦t miss Two cases for a task that writes under a temporary name, renames it into place and reads it back. In `folder_renamed_into_place`, the task writes `tmp/a.js`, renames `tmp` to `deps` and reads `deps/a.js`, through `vtt fs`, which gets a `rename` operation, like Vite's dependency optimizer renaming `deps_temp_*` to `deps`. In `vitest_fs_module_cache`, Vitest 5 with `fsModuleCache` writes each transformed module to `node_modules/.vitest-cache/.tmp-*`, renames it to a hashed name in the same folder and reads it back. Today the renamed paths are plain inputs, since a rename isn't recorded as a write, so removing them, as on a clean checkout, is a cache miss, and they aren't in the cached outputs. The Vitest case removes `node_modules/.vitest-cache` and `node_modules/.vite/vitest`, not all of `node_modules/.vite`, which holds the task cache too, and recreates nothing, as on a clean checkout. Several inputs are then missing, and vt names whichever its parallel validation finds first, so the next step redacts its miss reason. The e2e harness redacts SHA-1 hex digests, since Vitest's entry names hash the module's absolute path. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
wan9chi
force-pushed
the
feat/cache-rename-targets
branch
from
November 5, 2026 09:02
b3a0de9 to
a2f93cc
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
β Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a2f93cc. Configure here.
A task that writes under a temporary name and renames the result into place, like Vitest's `fsModuleCache` renaming each `.tmp-*` file to its hashed name, or Vite's dependency optimizer renaming `deps_temp_*` to `deps`, left those paths as plain inputs: fspy recorded nothing for a rename, so they weren't archived, a hit didn't restore them, and removing them, as on a clean checkout, was a cache miss. fspy now records the destination of a rename as a rename target, a new access kind, since it may be a whole folder, and the destination of a hard link, always a file, as a write. Both are recorded before the call, so a failed call is recorded too. The source of a rename needs no record. - Unix preload: `rename`, `renameat`, `link` and `linkat`, plus `renameat2` on Linux and `renamex_np` and `renameatx_np` on macOS. - Linux seccomp supervisor, for static binaries: `renameat`, `renameat2` and `linkat`, plus `rename` and `link` on x86_64. - Windows: `NtSetInformationFile` with `FileRenameInformation(Ex)` or `FileLinkInformation(Ex)`, where `MoveFileExW`, `CreateHardLinkW` and `SetFileInformationByHandle` end. A bare name with no `RootDirectory` renames within the source's folder, so it's resolved against that. `Rebuildable` now takes rename targets next to writes. A rename target that is a file counts as written; one that is a folder after the run stands for every file or symlink under it, recursively, while the folder and the folders in it don't count as written. A write record on a path that is a folder, from opening it with write access, is ignored, so it can't pull in the files under it, and `Rebuildable::may_be_missing` never takes it for a file the task wrote. The files of a renamed folder may be missing on the next run and make their folder rebuildable. The archive takes them like any written file, so a hit restores them if they're among the task's outputs. The folder a task filled and renamed away, like Vite's `deps_temp_*`, is gone after the run, so a probe of it was stored as a plain `NotFound` input with a new name in every entry. A path that is gone after the run but that the task wrote in now counts as written: the task made or removed it. Validation doesn't change, since a stored `NotFound` must be missing either way. A `.DS_Store` under a renamed folder doesn't count, as in listings. Written paths aren't stat'd: a written path that is a folder only needs telling apart where the task read it, so `may_be_missing` stats only a written path that a read found as a folder; rename targets are, to find the folders to expand. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
wan9chi
force-pushed
the
feat/cache-rename-targets
branch
from
November 5, 2026 09:16
a2f93cc to
96ef5e4
Compare
wan9chi
added a commit
that referenced
this pull request
Nov 5, 2026
## Motivation Follow-ups to the rebuildable-inputs stack (#913β#919, #940, #941), now merged: - The real-world case for files renamed into place (#916) used Vitest's `fsModuleCache`, which renames cache entries rather than outputs. - #919's e2e cases test a listing entry like any other, so they add no coverage of their own. - The stack added eight changelog entries, most of them for what users see as one feature. - Socket flagged Astro 6.4.8, which #917 added for its real-world case: critical advisory GHSA-26w7-cxv4-gfx2 (remote code execution through AVIF image optimization), fixed in Astro 7.2.8. ## Changes - New case `next_build_moved_pages`: Next.js 15's `next build` renders each static page (`index.html`, `404.html`, `500.html`) into `.next/export` and renames it into `.next/server/pages`. After `.next` is removed, the next run is a cache hit that restores the pages. The build log is redacted, since its progress lines, sizes and chunk hashes vary. It replaces `vitest_fs_module_cache`, along with the SHA-1 redaction only that case used. `next`, `react` and `react-dom` join `packages/tools`. - `dist_appears_in_listed_folder` and `oxlint_dist` are removed. - The changelog entries of #913β#918 are combined into one **Added** item for rebuildable inputs; #919 (`dist` in listings) and #941 (input exclusions apply to listings) stay their own short items, and so does #940's fix. - On Windows CI, the e2e harness stages fixtures in `RUNNER_TEMP`, on the checkout's drive: the staged workspaces resolve `node_modules` into the checkout, and Next.js builds its client entry from a path relative to the project, which can't cross drives. - Astro 6.4.8 β 7.3.8, the newest release that still supports the repo's Node 22.19. Astro 7 needs upstream Vite 8, so its scoped override now points at Vite 8.3.2. `astro_empty_collections` passes unchanged; its comment now says Astro 7 stats the project root rather than listing it. π€ Generated with [Claude Code](https://claude.com/claude-code) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Test harness, changelog, and dependency catalog changes only; no changes to task caching or file-tracking behavior in this diff. > > **Overview** > Follow-up after the rebuildable-inputs stack lands: **no runtime cache logic changes**βmostly release notes, snapshot tests, and toolchain bumps. > > The **changelog** folds the former #913β#918 narrative into one **Added** βrebuildable inputsβ entry and shortens the #919 / #941 **Changed** bullets; #940 stays separate. > > **E2E snapshots** swap coverage: **`next_build_moved_pages`** (Next.js 15 renaming `.next/export` β `.next/server/pages`, cache hit after deleting `.next`) replaces **`vitest_fs_module_cache`**; **`dist_appears_in_listed_folder`** and **`oxlint_dist`** are dropped as redundant with listing behavior elsewhere. Snapshot **redaction** drops SHA-1 normalization (Vitest-only). On **Windows CI**, fixtures stage under **`RUNNER_TEMP`** so Nextβs client entry paths stay on the checkout drive. > > **Deps**: catalog adds **Next 15**, **React 19**, bumps **Astro 6 β 7.3.8** (security advisory), and scopes **`astro>vite`** to upstream **Vite 8.3.2**. The Astro empty-collections fixture comment reflects Astro 7 **stat**-ing the project root instead of listing it. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 4c8f40c. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
fengmk2
added a commit
to voidzero-dev/vite-plus
that referenced
this pull request
Nov 11, 2026
Vite+ 1.6.0 caches `vp run` tasks that rewrite files they read, previews runs with `vp run --dry-run` and JSON output, lets `vp check --continue-on-error` report every failed check, and sets `VP_USER_AGENT` for the tools that `vp` starts. ### Features - `vp run` caches tasks that read files they also write, such as `tsdown --exports` rewriting `package.json` or `tsc --incremental` reading and writing `tsconfig.tsbuildinfo`. The files a task writes, and folders that hold only those files, may be missing on the next run, as on a fresh clone, and a cache hit restores them with the task's outputs, including the symbolic links the task created ([docs](https://viteplus.dev/guide/automatic-data-tracking#rebuildable-inputs)) ([vite-task#913](voidzero-dev/vite-task#913), [vite-task#914](voidzero-dev/vite-task#914), [vite-task#915](voidzero-dev/vite-task#915), [vite-task#916](voidzero-dev/vite-task#916), [vite-task#917](voidzero-dev/vite-task#917), [vite-task#918](voidzero-dev/vite-task#918)), by @wan9chi. - `vp run --dry-run` shows each command that a run would start and whether it would hit the cache, without running anything or writing to the cache. `vp run --json` prints every package and task in the workspace, and `vp run --dry-run --json` prints the run plan with each step's cache status, as one JSON document for scripts, CI, and coding agents. `vp run -v` lists every change behind a cache miss, including each changed input file, and `-vv` also lists the unchanged inputs and the outputs that a hit restores ([docs](https://viteplus.dev/guide/run#dry-runs-and-json-output)) ([vite-task#948](voidzero-dev/vite-task#948), [vite-task#960](voidzero-dev/vite-task#960), [vite-task#961](voidzero-dev/vite-task#961), [vite-task#963](voidzero-dev/vite-task#963), [vite-task#966](voidzero-dev/vite-task#966), [vite-task#967](voidzero-dev/vite-task#967), [vite-task#968](voidzero-dev/vite-task#968), [vite-task#969](voidzero-dev/vite-task#969)), by @wan9chi. - `vp check --continue-on-error` runs the remaining enabled checks after a failure, so one run reports formatting, lint, and type errors together, and exits with the status of the first failed check. Without the flag, `vp check` still stops at the first failed check ([#3367](#3367)), by @chbaefront. - `vp`, `vpr`, and `vpx` set `VP_USER_AGENT=vp/<version>` for their child processes, so tools can detect that Vite+ started them. When the global CLI delegates to a project's local CLI, the local version is reported ([docs](https://viteplus.dev/guide/global-cli#vp-user-agent)) ([#1958](#1958)), by @fengmk2. - First part of `VP_ENV_FORBIDDEN=1`, for systems such as NixOS that provide Node.js and package managers themselves: with it set, Vite+ never downloads a Node.js or package-manager version, shims and `vpx` use only the system tools on `PATH`, and installers and `vp upgrade` use the system `node` and `pnpm` for Vite+'s own dependencies. In this release, commands that delegate to a package manager, such as `vp install` and `vp run`, fail with `DisabledByEnvForbidden` while it is set. A follow-up change is planned to cover them and document the variable ([#3233](#3233)), by @myuron. - Upgrade the bundled Oxfmt and Oxlint ([#3416](#3416)), by @voidzero-guard[bot]: - `oxfmt@0.76.0` to `oxfmt@0.78.0`. Oxfmt formats Vue files with its own formatter instead of Prettier, so the output for Vue templates can change. It also fixes Tailwind class sorting in several layouts, Less escapes and `%` selectors, and TypeScript in Astro files. - `oxlint@1.91.0` to `oxlint@1.93.0` and `oxlint-tsgolint@7.0.2005` to `oxlint-tsgolint@7.0.2006`. `no-redeclare` gets an `ignoreDeclarationMerge` option, and `promise/prefer-catch` offers a suggestion. - Oxlint and Oxfmt resolve an unset or relative `root` in `vite.config.ts` from the directory of the config file instead of the current directory, so editor integrations in multi-root workspaces load the correct project. - Vite+ installs its own dependencies during setup and `vp upgrade` with `pnpm@10.34.9` (was `pnpm@10.34.7`). - The new Oxfmt and Oxlint can flag code that passed before. If your CI runs `vp check`, run `vp check --fix --continue-on-error` after you upgrade: it formats files, applies the available lint fixes, formats again, and reports every error that remains. For example, `unicorn/prefer-type-error` now also reports a `throw` in an `if` branch without braces, and this command rewrites it. ### Fixes & Enhancements - While a Vite+ spinner is visible, such as `Installing global packages` in `vp install -g`, Vite+ hides the cursor and discards typed keys. Pressing Enter no longer leaves copies of the spinner row, and typed text no longer runs in the shell after the command ends. Ctrl+C during a spinner now ends the command with the usual signal status instead of exit code 0, and the global package spinners show the elapsed time ([#3373](#3373), [#3417](#3417)), by @jong-kyung and @fengmk2. - `vp run` loads a package's `vite.config.*` only when the run reaches one of that package's tasks. A run in one package no longer waits for the configs of other packages, a broken config in another package no longer fails it, and `vp run <task>` in a package that does not define the task reports `Task "<task>" not found` instead of another package's config error ([vite-task#944](voidzero-dev/vite-task#944), [vite-task#988](voidzero-dev/vite-task#988)), by @wan9chi. - `vp run nope#build`, where no workspace package has the name `nope`, fails with `Package 'nope' not found in the workspace` and exits with code 1, instead of running nothing and exiting with code 0. A short name that matches several scoped packages fails as ambiguous ([vite-task#984](voidzero-dev/vite-task#984)), by @wan9chi. - Folder listings no longer skip entries named `dist`, so a `dist` folder that appears or disappears in a folder a task lists makes the next run a cache miss. Exclusions in a task's `input`, such as `"!dist/**"`, now also apply to the folders that the task lists. In a new monorepo from `vp create`, every task hits the cache from the third `vp run ready`, because the first build creates the `dist` folders ([vite-task#919](voidzero-dev/vite-task#919), [vite-task#941](voidzero-dev/vite-task#941)), by @wan9chi. - Fewer unnecessary cache misses and cache failures in `vp run`: on Windows, files that a task deletes or moves are no longer among its inputs. Tasks that read `node_modules/.vite/task-cache`, as Parcel and Gatsby do, hit the cache. A task that writes outside the workspace through `..`, like `cp -r dist ../site`, no longer fails with `Cache update failed` ([vite-task#937](voidzero-dev/vite-task#937), [vite-task#940](voidzero-dev/vite-task#940), [vite-task#980](voidzero-dev/vite-task#980)), by @wan9chi. - A cache hit restores the symbolic links that a task's `output` globs match as links, instead of dropping them ([vite-task#885](voidzero-dev/vite-task#885)), by @jasonkuhrt. - When several tasks become ready at the same time, `vp run` checks their cache entries in parallel, so cache hits start sooner ([vite-task#982](voidzero-dev/vite-task#982)), by @wan9chi. - On macOS, task commands that use `sh` or `bash` behave as on Linux: a `while read` loop with a redirect under `set -e` no longer exits the script, an `EXIT` trap sees the exit status, so a failed task is no longer reported as successful, and `$BASH` is set ([vite-task#939](voidzero-dev/vite-task#939)), by @lifeiscontent. - The helper files that `vp run` writes to the system temp directory go in one folder that only the current user can write to, such as `/tmp/vp_run-1000` on Linux. On Linux, a different Vite+ version run by another user no longer fails ([vite-task#947](voidzero-dev/vite-task#947), [vite-task#974](voidzero-dev/vite-task#974)), by @wan9chi. - A `getEnvs` query from `@voidzero-dev/vite-task-client` that matches every name (`{ prefix: '' }` or `*`) returns nothing and no longer adds every environment variable to the cache key ([vite-task#976](voidzero-dev/vite-task#976)), by @wan9chi. - `vp migrate` no longer writes package specs that the package manager cannot resolve, such as a `@vitest/*` `catalog:` reference without a catalog entry or a top-level catalog on Bun before 1.2.21. Bun projects with an empty `workspaces` field get catalog references, and child packages with a plain `vite-plus` range get the same concrete version as the root when the project cannot use catalogs ([#3397](#3397)), by @jong-kyung. - `vp create` uses the package manager version that `VP_PACKAGE_MANAGER` selects for the generated settings, the installation, and its summary. Standalone pnpm projects get `packages: ['.']` in an existing `pnpm-workspace.yaml` only for pnpm before 10.5.0 ([#3197](#3197)), by @evan-lc and @fengmk2. - `vp` sends a `User-Agent` header on all HTTP requests, so Node.js mirrors that reject requests without one, such as `mirrors.aliyun.com`, work ([#3425](#3425)), by @naokihaba. - `vp env pin` prints `Updated` when it overwrites an existing `.node-version` or `.nvmrc` file and `Created` when it writes a new one ([#3377](#3377)), by @CheHyeonYeong. ### Docs - Describe rebuildable inputs in the Automatic Data Tracking guide, and dry runs, JSON output, and `-vv` in the `vp run` guide ([#3419](#3419), [#3421](#3421)), by @wan9chi. ### Chore - Bump vite-task to `cb1ea8d`, with its user-facing changes listed above, and list `--dry-run`, `--json`, and `-vv` in `vp run --help` ([#3418](#3418)), by @wan9chi. - The daily dependency upgrade also updates the pnpm version that the installers pin, after it checks the release integrity ([#3407](#3407)), by @fengmk2. - Warm up the monorepo cache check in the `vp create` CI job under pnpm and Bun ([#3423](#3423)), by @wan9chi. - Remove an unused CI job that the required `done` check did not cover ([#3403](#3403)), by @jong-kyung. - Remove an incorrect comment about export pattern order in the CLI build script ([#3405](#3405)), by @alexicum. ### Bundled Versions | Tool | Version | Source | Changelog | | --------------- | ---------- | ---------------------------------------------------------------------------------------------------- | ----------------------------------------------------------------------------------------------------------------------------------------------- | | vite | `8.3.7` | [`5def936`](vitejs/vite@5def936) | unchanged | | rolldown | `1.2.18` | [`f9a49d6`](rolldown/rolldown@f9a49d6) | unchanged | | oxc-node | `1.0.1` | [`7ff14c3`](oxc-project/oxc-node@7ff14c3) | unchanged | | tsdown | `0.23.4` | [npm](https://npmx.dev/package/tsdown/v/0.23.4) | unchanged | | vitest | `5.1.0` | [npm](https://npmx.dev/package/vitest/v/5.1.0) | unchanged | | oxlint | `1.93.0` | [npm](https://npmx.dev/package/oxlint/v/1.93.0) | [1.92.0](https://github.com/oxc-project/oxc/releases/tag/oxlint_v1.92.0), [1.93.0](https://github.com/oxc-project/oxc/releases/tag/oxlint_v1.93.0) | | oxlint-tsgolint | `7.0.2006` | [npm](https://npmx.dev/package/oxlint-tsgolint/v/7.0.2006) | [7.0.2006](https://github.com/oxc-project/tsgolint/releases/tag/v7.0.2006) | | oxfmt | `0.78.0` | [npm](https://npmx.dev/package/oxfmt/v/0.78.0) | [0.77.0](https://github.com/oxc-project/oxc/releases/tag/oxfmt_v0.77.0), [0.78.0](https://github.com/oxc-project/oxc/releases/tag/oxfmt_v0.78.0) | ### Upgrade ```bash vp upgrade ``` If `vp upgrade` must download Node.js and `VP_NODE_DIST_MIRROR` points to a mirror that rejects requests without a `User-Agent` header, such as `mirrors.aliyun.com`, unset it or point it to another mirror for this upgrade. The installed `vp` downloads Node.js and does not send the header yet. ### New Contributors @alexicum, @evan-lc, @CheHyeonYeong **Full Changelog**: v1.5.1...v1.6.0 --- For a stable release, complete the `HomebrewFormula/vp.rb` update after publication by merging the generated `release/homebrew-v1.6.0` PR. Merging this PR will trigger the release workflow. --------- Co-authored-by: voidzero-guard[bot] <278573678+voidzero-guard[bot]@users.noreply.github.com> Co-authored-by: MK (fengmk2) <fengmk2@gmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Motivation
Many tools write under a temporary name and rename the result into place:
fsModuleCacherenames each.tmp-*file to its hashed name.deps_temp_*todeps..astro/*.tmpand renames them.fspy records nothing for a rename, so those files aren't outputs. A hit doesn't restore them, and since the task reads them back, removing them is a miss.
Changes
RenameTarget, since it may be a whole folder. A hard-link destination, always a file, is recorded as a write. Both are recorded before the call. This covers the Unix preload, the Linux seccomp supervisor and WindowsNtSetInformationFile.deps_temp_*, filled and renamed away, isn't stored as aNotFoundinput with a new name in every entry.E2E cases:
folder_renamed_into_place(synthetic,vtt fs rename) andvitest_fs_module_cache(Vitest 5 withfsModuleCache, true clean checkout, its today's miss line redacted with #912'sredact). fspy tests coverrenameat2(preload and seccomp),renamex_np/renameatx_np, destinations relative to a folder handle, and Windows renames relative to aRootDirectoryhandle.Part of a stack that lets automatic tracking cache tasks which read their own outputs and list the folders holding them, so they also hit on a clean checkout.
π€ Generated with Claude Code
Note
Medium Risk
Changes cross-platform fspy hooks and post-run cache fingerprinting/archiving; incorrect tracking would cause false hits or misses, though coverage is extensive.
Overview
Automatic file tracking now sees renames and hard links: rename destinations are recorded as
RenameTarget(hard-link destinations as writes), before the syscall returns, on Unix preload and seccomp paths and via WindowsNtSetInformationFile. Shared IPC adds the new access kind;vtt fs renamesupports e2e simulation.Cache logic folds rename targets into
Rebuildable: a renamed file counts as written; a renamed folder expands to every file under it for archiving and fingerprinting. Temp paths that disappear after a rename (e.g. Vitedeps_temp_*) are treated as written-in folders so they donβt spuriously invalidate inputs. Spurious βwriteβ on a directory from opening it for write is ignored.Outcomes: auto-tracked outputs include rename-into-place and hard-link results; cache hits can restore them on a clean checkout when the task reads them back. E2e covers
folder_renamed_into_placeand VitestfsModuleCache(ignored snapshot).Reviewed by Cursor Bugbot for commit 96ef5e4. Bugbot is set up for automated code reviews on this repo. Configure here.