🔴 Live TV: webpro nl/knip/pull/

caseycarroll · 2026-07-29T20:51:48Z

Adds a marko plugin to knip to analyze dependencies in .marko files.

Marko has an auto tag discovery feature which allows authors to use custom tags without explicitly importing them. To support this, this plugin will look for Marko in the dependencies then look for marko.json files for each project dependency in node_modules. It will then find tag names in the locations specified in marko.json and check that at least one of the tag names is used in the project.

The marko.json parsing is intentionally limited. It only looks at exports and tags-dir because other mechanisms like taglib-imports will be deprecated. If a Marko dependency exposes tags with a deprecated property, the plugin will categorize the dependency as used without searching for usages in the project code.

This plugin also naively covers marko's "concise syntax" since it's not widely used. A follow up PR could add stronger concise syntax support, if the community needs it. https://markojs.com/docs/reference/concise-syntax

Additional Changes

Appears the OpenClaw plugin was not accounted for in the docs list, so it's been added to plugins.md as well as marko.

AI Disclosure

I authored the PR description in my own words and reviewed the code manually, but did use a model to implement the plugin and fixtures.

This reverts commit 066c15b.

This reverts commit f0c42b5.

webpro

Thanks for the pull request! Would be cool to add Marko plugin. I do have a note.

webpro · 2026-07-30T04:55:22Z

@@ -1,5 +1,5 @@
 ---
-title: Plugins (177)
+title: Plugins (179)


Please undo changes in this file, we can auto-generate separately (and they're always re-generated for website deploy).

Great! Removed.

webpro · 2026-07-30T05:16:17Z

+  /^[ \t]*(export\s+(?:type\s+)?(?:\*(?:\s+as\s+[$\w]+)?|\{[^}]*\})\s+from\s+(["'])([^"'\r\n]+)\2)[ \t]*;?/gm;
+const conciseStyleMatcher = /^[ \t]*style(?:\.([\w.-]+))?[^\n{]*\{([\s\S]*?)^[ \t]*\}/gm;
+const htmlTagMatcher = /<([a-z][\w.-]*)(?=[\s/|>])/g;
+const conciseTagMatcher = /^[ \t]*([a-z][\w.-]*)(?=[ \t/|]|--|$)/gm;


The import/export/dynamic-import matchers reimplement what oxc-parser does out of the box. How about this: instead of reconstructing statements with regexes, the compiler could reduce the source to parseable JS (and let the parser do its job):

Strip comments and style blocks (still compiling styles separately as it does now), lines starting with <, and import ... from "<tag>" lines.

Neutralize the Marko-only syntax so a hard error can't land before the imports: server/client/static/$ prefixes, the anonymous class { (give it a name), and the export modifier on local declarations (export interface Input must not surface as an unused export).

Return the synthetic imports (marko, taglib dependencies, compiled styles) followed by the remainder verbatim. Synthetic lines go first: a parse error in markup leftovers truncates the module record from that point on, so the leftovers must come last.

No parsing in the compiler: the pipeline picks up static, dynamic and type imports and re-exports in any shape, quoted attribute values are inert to the tokenizer, and dynamic imports inside the class block get picked up too.

To me this feels sturdier and easier to maintain. Even though Marko syntax might change, using regexes for what oxc-parser does better feels a bit cumbersome.

WDYT?

Agreed this feels cumbersome! I like your suggested approach. Will tinker with that and follow up soon.

Okay, refactored to have a tag dependency pass, a style pass, then a stage where I sanitize the .marko template so parseable JS is fed into oxc-parser.

I've added regex's to account for different marko syntax things like class {}.

webpro

Thanks for the updates! Almost good to go.

Optional: a fixture with a marko.json that has neither exports nor tags-dir would pin the taglib-imports fallback ("conservatively considered used") behavior.

webpro · 2026-07-31T06:02:21Z

+];
+
+const tagProduction = tagFilePatterns.map(pattern => `**/{${tagDiscoveryDirs.join(',')}}/${pattern}`);
+export const production = tagProduction;


Suggested change

export const production = tagProduction;

const production = tagProduction;

It's in the default plugin export obj.

webpro · 2026-07-31T06:13:27Z

+Local tag templates and their conventionally associated component and style files in \`components\`
+(Marko 5) or \`tags\` (Marko 6) are conservatively treated as production entries. Knip does not
+report unused auto-discovered local tags inside those directories. Modern Marko 5
+\`marko-tag.json\` entry points and compiler hooks are also resolved.`;


Please remove docs and note entirely. They look like implementation details, not documenting surprising behavior with answers / workarounds users need to know about.

Removed the docs. I should have cross-validated with other plugins here, my bad!

webpro · 2026-07-31T06:16:19Z

+const compiler = createCompiler();
+
+export default compiler;


Suggested change

const compiler = createCompiler();

export default compiler;

webpro · 2026-07-31T14:42:02Z

🚀 This pull request is included in v6.31.0. See Release 6.31.0 for release notes.

Using Knip in a commercial project? Please consider becoming a sponsor.

webpro · 2026-07-31T14:48:18Z

Thanks again, Casey — nice one.

Casey Carroll added 11 commits July 26, 2026 09:13

agent-assist initial pass at knip marko plugin

ac56011

clean up fixture stubs

1cfef27

use compiler

ff5dc21

rewrite to avoid using compiler and language tools

463db82

rm marko run stuff

9467098

support determining auto tag discovery usage

c9c714e

Fix multiline Marko imports

9fe7d8b

Support concise Marko style blocks

f0c42b5

Handle concise Marko style fences

066c15b

Revert "Handle concise Marko style fences"

2379a86

This reverts commit 066c15b.

Revert "Support concise Marko style blocks"

c62aba9

This reverts commit f0c42b5.

webpro reviewed Jul 30, 2026

View reviewed changes

Casey Carroll added 5 commits July 30, 2026 10:51

Support legacy Marko tags directories

364c116

Undo generated plugin documentation

b9a41a6

Let parser discover Marko imports

ee5e29a

Harden Marko source sanitizing

6c6f1dd

Handle lazy Marko tag imports

a3cc98b

caseycarroll marked this pull request as ready for review July 30, 2026 19:59

webpro reviewed Jul 31, 2026

View reviewed changes

Casey Carroll added 3 commits July 31, 2026 06:27

rm docs

8f9d17c

rm unused exports

917bc36

Test Marko taglib imports fallback

91cf347

webpro merged commit c6b1516 into webpro-nl:main Jul 31, 2026

abrahamguo mentioned this pull request Oct 25, 2026

Generate built-in compilers list from source #2216

Merged

	export const production = tagProduction;
	const production = tagProduction;

Conversation

caseycarroll commented Jul 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Additional Changes

AI Disclosure

Uh oh!

webpro left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

webpro left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

webpro commented Jul 31, 2026

Uh oh!

webpro commented Jul 31, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

caseycarroll commented Jul 29, 2026 •

edited

Loading