Repository navigation
fix(serverless-framework): handle explicit extensions in handler paths - #2091
Merged
webpro merged 1 commit intoOct 4, 2026
Merged
Conversation
commit: |
webpro
approved these changes
Oct 4, 2026
webpro
left a comment
webpro
left a comment
Member
There was a problem hiding this comment.
Thanks for the fix! This correctly recognizes explicit .js and .cjs handler paths supported by Serverless v3 local invocation.
Member
|
🚀 This pull request is included in v6.40.0. See Release 6.40.0 for release notes. Using Knip in a commercial project? Please consider becoming a sponsor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a Serverless handler specifies its source extension, such as
function/handler.js.handler, Knip appended{js,ts}to the path and searched forfunction/handler.js.{js,ts}. As a result, the actual handler file could be incorrectly reported as unused.Solution
Preserve explicit JS/TS-family extensions in handler paths. Continue searching both
.jsand.tswhen the handler path has no explicit source extension. Updated the Serverless fixture and added a regression assertion that the explicit.jshandler is not reported as unused.