[jay23606]

Summary

• Recognize only a directly awaited dynamic import inside a try/catch as a caught optional peer reference.
• Preserve diagnostics for undeclared packages and missing relative imports, and preserve the existing new URL() optional peer behavior.
• Keep optional peer type dependencies referenced in default and strict modes.

Tests

• Before the fix: the focused caught-import regression failed because the declared optional peer was reported as unlisted.
• After the fix: bun test test/dependencies/peer-dependencies-optional-strict.test.ts — 13 passed.
• pnpm run build — passed.
• pnpm run lint — passed.
• git diff --check — passed.

Not verified

• The wider test suite and smoke suite were not run; only the affected test file was run.

Fixes #2214

🤖 Generated with Claude Code

[webpro]

Thanks for picking this up, Jay, the scope is right: a directly awaited import() inside try with a catch, nothing else. The implementation reuses IMPORT_FLAGS.OPTIONAL though, and that flag already means "no error if not resolved" for new URL(x, import.meta.url) and /// <reference path>. Reusing it changes behavior in both directions, and the new fixture never reaches the code that implements the policy. Details inline.

Suggested shape for the next round:

• Add a separate CAUGHT flag in IMPORT_FLAGS and leave OPTIONAL untouched.
• Set it only when the ImportExpression is the direct argument of an AwaitExpression.
• Pass it through DependencyReferenceOptions and let DependencyDeputy.isInDependencies accept optional peers when strict and caught, so @types attribution and the default mode stay as they are. Then the analyze.ts change is not needed.
• Track try protection in the walker with the existing TryStatement and :exit hooks instead of re-walking the block.
• Install optional-peer in the fixture's node_modules (as peer-dependencies-optional-strict-unreferenced does), assert counters, and add regressions for a caught import of an unlisted package and of a missing local file.

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/knip@2218

npm i https://pkg.pr.new/@knip/language-server@2218

npm i https://pkg.pr.new/@knip/mcp@2218

commit: 1f8b07c

[webpro]

Thanks for the quick turnaround, this is much closer. The separate CAUGHT flag, the deputy-owned policy, the direct-argument await check and the stack-based try tracking all do what they should, and my earlier probes match main again. Two things remain, and the first one is what #2214 is about: const mod = await import('pg') inside try/catch is still unlisted in strict mode. The other is that the new URL case was turned into a new policy instead of being left as it was. Details inline, plus two branches that turned out to be unnecessary and can go.

Optional: the strict mode section in packages/docs/src/content/docs/features/production-mode.md could mention that an optional peer is accepted when its awaited import() is wrapped in try/catch.

[webpro]

All five points from the last round are addressed, thanks. The declarator forms go through the try stack, OPTIONAL is back to its original meaning, the two redundant branches are gone, and the fixtures are precise. My probe set against main shows default mode unchanged everywhere and strict mode changing only for the caught forms. Two small things are left before this can go in: a formatting failure in walk.ts that CI will flag, and Promise.all being accepted in only one of its forms. Both inline.

[webpro]

Thanks for the quick follow-up! Both points are fixed: the formatting check passes, and an awaited Promise.all is now caught in the statement, return and assignment forms too, with the fixture covering the statement form next to the destructured one. Default mode is still unchanged, and strict mode only changes for the caught forms.

One more change before merging, see the inline comment. I also noticed the commits are co-authored by Claude Haiku 5.5. The walker is core logic that every Knip run goes through, so for changes like this please use a stronger model and review its output closely before pushing.

[webpro]

Thanks for the refactor! getPromiseAllElements is now the single owner of the check, both call sites use it without changing behavior, and the walker's hot path is the same as before. Looks good to me.

[webpro]

🚀 This pull request is included in v6.44.0. See Release 6.44.0 for release notes.

Using Knip in a commercial project? Please consider becoming a sponsor.