Repository navigation
Read .mocharc.mjs in the Mocha plugin - #2259
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
commit: |
Member
|
Thank you! Next time, for such a small change we can probably reuse existing fixture folder. |
Member
|
π This pull request is included in v6.44.1. See Release 6.44.1 for release notes. Using Knip in a commercial project? Please consider becoming a sponsor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mocha reads
.mocharc.mjsas well as.mocharc.{cjs,js,yaml,yml,jsonc,json}(CONFIG_FILESinlib/cli/config.cjs, mocha 12.0.3). The Mocha plugin only listed.mocharc.{js,cjs,json,jsonc,yml,yaml}, so with an.mjsconfig itsspec,file,requireandreporterentries were never read: spec files showed up as unused files and an external reporter as an unused dependency.This adds
mjsto the config pattern.New fixture
plugins/mocha-config-mjshasspecandreporterin.mocharc.mjs(plus the samenode_modules/mochastub as themocha2fixture). Without the change the test fails (specs/example.test.jsis reported as unused); with it the spec file andmocha-junit-reporterare picked up and onlyunrelated.jsis reported.Checks:
node scripts/run-test.js --runtime node(1627 pass, afterpnpm build),pnpm lint,oxfmt --checkon the changed files.I used Claude Code (AI) to write this change, and checked mocha's source for the supported config file names.
π€ Generated with Claude Code