🔴 Live TV: webpro nl/knip/pull/

everton-dgn · 2026-11-03T05:30:06Z

Follow the command passed to vp exec so its scripts are discovered without manual entry configuration. The resolver preserves quoted arguments, -- and the three leading -C forms, including absolute paths. Other subcommands return only the vp binary.

Registering vp as a package manager also lets mise tasks follow its commands and apply the same binary checks as package scripts.

Tested with parser regressions that fail without the fix, the CLI reproduction from the issue, pnpm run ci and the full pnpm qa.

pkg-pr-new · 2026-11-03T05:30:48Z

Open in StackBlitz

npm i https://pkg.pr.new/knip@2285

npm i https://pkg.pr.new/@knip/language-server@2285

npm i https://pkg.pr.new/@knip/mcp@2285

commit: 3e87cd9

webpro

Thanks Éverton, this finds the script for the case in #2284. Two forms still resolve the wrong file: -c with more than one argument, and -w. Suggestions for both are inline, with tests and two small cleanups.

webpro · 2026-11-03T09:23:45Z

+
+  const dir = C ? toAbsolute(C, options.cwd) : undefined;
+  const rest = words.slice(commandIndex);
+  const script = execOptions['shell-mode'] && rest.length === 1 ? rest[0].value : rest.map(word => word.text).join(' ');


With -c, Vite+ joins all arguments and passes the result to the shell, so vp exec -c "node ./scripts/proof.mjs" --flag runs scripts/proof.mjs. With more than one word here, the whole quoted command becomes a single entry and the script is still reported as unused. Using word.value for every word in shell mode covers both cases:

Suggested change

const script = execOptions['shell-mode'] && rest.length === 1 ? rest[0].value : rest.map(word => word.text).join(' ');

const script = rest.map(word => (execOptions['shell-mode'] ? word.value : word.text)).join(' ');

@webpro

Fixed in 4b2e73a. Shell mode now joins word.value for every argument, with a regression for -c "node ./script.js" --flag.

webpro · 2026-11-03T09:23:45Z

+  const execOptions = parseArgs(words.slice(execIndex + 1, commandIndex), parseOptions);
+  if (execOptions.filter && !execOptions.recursive) return [binary];
+
+  const dir = C ? toAbsolute(C, options.cwd) : undefined;


-w runs the command in the workspace root, so vp exec -w node ./scripts/root.mjs in a package script runs the root's scripts/root.mjs. Since it's resolved against the package, a scripts/root.mjs in the package is marked as used instead, and the root file is still reported as unused:

Suggested change

const dir = C ? toAbsolute(C, options.cwd) : undefined;

const dir = execOptions['workspace-root'] ? options.rootCwd : C ? toAbsolute(C, options.cwd) : undefined;

@webpro

-w now resolves against options.rootCwd in 4b2e73a, including when -C is set. Added cases for a package cwd and workspace-root precedence.

webpro · 2026-11-03T09:23:46Z

+  if (commandIndex === undefined) return [binary];
+
+  const execOptions = parseArgs(words.slice(execIndex + 1, commandIndex), parseOptions);
+  if (execOptions.filter && !execOptions.recursive) return [binary];


Vite+ rejects --filter together with --recursive ("--filter and --recursive cannot be used together"), so this can be simpler:

Suggested change

if (execOptions.filter && !execOptions.recursive) return [binary];

if (execOptions.filter) return [binary];

@webpro

Simplified to if (execOptions.filter) return [binary]; in 4b2e73a.

webpro · 2026-11-03T09:23:46Z

+
+const parseOptions = {
+  isStorePositions: true,
+  string: ['C', 'filter', 'resume-from'],


A leading -C is already handled by parseLeadingChdir, and after exec Vite+ treats -C as the command, so 'C' isn't needed here:

Suggested change

string: ['C', 'filter', 'resume-from'],

string: ['filter', 'resume-from'],

@webpro

Removed C from the string options in 4b2e73a. Leading directory changes remain handled by parseLeadingChdir.

webpro · 2026-11-03T09:23:46Z

+  t('vp exec vitest --filter smoke', [toBinary('vp'), toBinary('vitest')]);
+  t(`vp -C ${app.dir} exec node ./scripts/task.mjs`, [toBinary('vp'), toBinary('node', app), toDeferResolveEntry('./scripts/task.mjs', { ...opt, ...app })]);
+  t('vp -Cpackages/app exec node ./scripts/task.mjs', [toBinary('vp'), toBinary('node', app), toDeferResolveEntry('./scripts/task.mjs', { ...opt, ...app })]);
+  t(`vp -C${app.dir} exec node ./scripts/task.mjs`, [toBinary('vp'), toBinary('node', app), toDeferResolveEntry('./scripts/task.mjs', { ...opt, ...app })]);


Could you add cases for these? The -c and -w lines fail without the changes above, and the -t line guards the flags that take no value:

Suggested change

t(`vp -C${app.dir} exec node ./scripts/task.mjs`, [toBinary('vp'), toBinary('node', app), toDeferResolveEntry('./scripts/task.mjs', { ...opt, ...app })]);

t(`vp -C${app.dir} exec node ./scripts/task.mjs`, [toBinary('vp'), toBinary('node', app), toDeferResolveEntry('./scripts/task.mjs', { ...opt, ...app })]);

t('vp exec -c "node ./script.js" --flag', [toBinary('vp'), toBinary('node'), js]);

t('vp exec -t node ./script.js', [toBinary('vp'), toBinary('node'), js]);

t('vp exec -w node ./script.js', [toBinary('vp'), toBinary('node', { dir: cwd }), toDeferResolveEntry('./script.js', { ...opt, dir: cwd })], { cwd: app.dir });

@webpro

Added the -c, -t, and package-cwd -w cases in 4b2e73a, plus precedence of --workspace-root over -C. The compact absolute -C case was already covered. Both bug regressions fail without the fix and pass with it.

everton-dgn · 2026-11-03T16:39:53Z

Fixed in 4b2e73a: shell-mode arguments, workspace-root resolution, the requested tests and both parser cleanups. pnpm run ci and pnpm qa pass (1,639 tests, 8 skipped).

webpro

Thanks, all five are in, and the extra --workspace-root case is a nice touch.

webpro · 2026-11-03T18:04:43Z

🚀 This pull request is included in v6.44.2. See Release 6.44.2 for release notes.

Using Knip in a commercial project? Please consider becoming a sponsor.

everton-dgn added 2 commits November 3, 2026 02:21

fix: resolve commands executed with vp exec

016a2d9

fix: preserve quoted executable paths in vp exec

a1c9a30

webpro requested changes Nov 3, 2026

View reviewed changes

everton-dgn added 2 commits November 3, 2026 13:10

fix: handle vp exec shell and workspace options

4b2e73a

chore: update sanity snapshot

3e87cd9

everton-dgn requested a review from webpro November 3, 2026 16:46

webpro approved these changes Nov 3, 2026

View reviewed changes

webpro merged commit 406a776 into webpro-nl:main Nov 3, 2026
32 checks passed

	const script = execOptions['shell-mode'] && rest.length === 1 ? rest[0].value : rest.map(word => word.text).join(' ');
	const script = rest.map(word => (execOptions['shell-mode'] ? word.value : word.text)).join(' ');

	const dir = C ? toAbsolute(C, options.cwd) : undefined;
	const dir = execOptions['workspace-root'] ? options.rootCwd : C ? toAbsolute(C, options.cwd) : undefined;

	if (execOptions.filter && !execOptions.recursive) return [binary];
	if (execOptions.filter) return [binary];

	string: ['C', 'filter', 'resume-from'],
	string: ['filter', 'resume-from'],

-  t(`vp -C${app.dir} exec node ./scripts/task.mjs`, [toBinary('vp'), toBinary('node', app), toDeferResolveEntry('./scripts/task.mjs', { ...opt, ...app })]);
+  t(`vp -C${app.dir} exec node ./scripts/task.mjs`, [toBinary('vp'), toBinary('node', app), toDeferResolveEntry('./scripts/task.mjs', { ...opt, ...app })]);
+  t('vp exec -c "node ./script.js" --flag', [toBinary('vp'), toBinary('node'), js]);
+  t('vp exec -t node ./script.js', [toBinary('vp'), toBinary('node'), js]);
+  t('vp exec -w node ./script.js', [toBinary('vp'), toBinary('node', { dir: cwd }), toDeferResolveEntry('./script.js', { ...opt, dir: cwd })], { cwd: app.dir });

Conversation

everton-dgn commented Nov 3, 2026

Uh oh!

pkg-pr-new Bot commented Nov 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webpro left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

everton-dgn commented Nov 3, 2026

Uh oh!

webpro left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

webpro commented Nov 3, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

pkg-pr-new Bot commented Nov 3, 2026 •

edited

Loading