[v-mahabaleshwars]

Description:

• Added support for using a github_token from the environment to make authenticated requests to GitHub, which helps avoid API rate limits when downloading GraalVM.
• Refactored the codebase for improved readability and maintainability.

Related issue:

Check list:

• Mark if documentation changes are required.
• Mark if tests were added or updated to cover the changes.

[robstoll]

out of curiosity, I also hit API Rate Limit issues when using jetbrains does your fix address this as well?

[Copilot]

Pull Request Overview

This pull request adds support for GitHub tokens to address API rate limits and refactors code for improved readability and maintainability.

• Introduces an optional token parameter to the GitHub HTTP headers helper.
• Refactors URL construction and error handling in the GraalVM installer.
• Updates associated tests with better grouping and improved mocking.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

File	Description
src/util.ts	Added an optional token parameter to getGitHubHttpHeaders to support GitHub token usage.
src/distributions/graalvm/installer.ts	Refactored file URL construction, error handling, and platform logic for the GraalVM installer.
tests/distributors/graalvm-installer.test.ts	Improved test grouping, added helpers for mocking HTTP responses, and refined architecture mapping tests.

Comments suppressed due to low confidence (1)

src/util.ts:186

• Consider updating the function's documentation or inline comments to clearly describe the new optional 'token' parameter and its behavior.

export function getGitHubHttpHeaders(token?: string): OutgoingHttpHeaders {

[Copilot]

[nitpick] Instead of returning early inside the test body to skip the unsupported Windows aarch64 case, consider using a conditional test skip (e.g. test.skip for that iteration) to make the intent clearer.

Suggested change

	return; // skip, aarch64 is not available for Windows
	test.skip('Skipping test: aarch64 is not available for Windows');

[fniephaus]

LGTM, thanks for adding support for authenticated requests to avoid hitting rate limits.

[fniephaus]

out of curiosity, I also hit API Rate Limit issues when using jetbrains does your fix address this as well?

@robstoll this PR is not touching the code responsible for pulling JetBrains JDKs. The relevant code seems to support the $GITHUB_TOKEN env var, but not the token option. Hope this helps.