Skip to content

Revert "fix(git): follow renames across merges in copyright creation year (#bug)" - #1078

Merged
mathieucarbou merged 1 commit into
masterfrom
revert-1077-fix/git
Jul 21, 2026
Merged

Revert "fix(git): follow renames across merges in copyright creation year (#bug)"#1078
mathieucarbou merged 1 commit into
masterfrom
revert-1077-fix/git

Conversation

@mathieucarbou

@mathieucarbou mathieucarbou commented Jul 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Owner

Reverts #1077

This PR fixes the issue in some cases as tested in the project but in some bigger, create a "deadlock" during the scan:

The refactoring in 1f29b8a replaced the O(n) FollowFilter approach with findCreationCommit, which walks the entire commit history and runs RenameDetector.compute() on every commit against every parent. RenameDetector uses SimilarityRenameDetector which does O(n²) content comparisons across all files in each diff — extremely expensive. And this happens per file.

Reverting until a better solution can be found.

@mathieucarbou mathieucarbou self-assigned this Jul 21, 2026
@mathieucarbou
mathieucarbou merged commit 590c91f into master Jul 21, 2026
18 checks passed
@mathieucarbou
mathieucarbou deleted the revert-1077-fix/git branch July 21, 2026 23:33
mergify Bot added a commit to ArcadeData/arcadedb that referenced this pull request Jul 26, 2026
@mergify
build(deps-dev): bump com.mycila:license-maven-plugin from 5.0.0 to 5…
9cdd4fe 
….1.1 [skip ci]

Bumps [com.mycila:license-maven-plugin](https://github.com/mathieucarbou/license-maven-plugin) from 5.0.0 to 5.1.1.
Release notes

*Sourced from [com.mycila:license-maven-plugin's releases](https://github.com/mathieucarbou/license-maven-plugin/releases).*

> v5.1.1
> ------
>
> What's Changed
> --------------
>
> * Revert "fix(git): follow renames across merges in copyright creation year (#bug)" by [`@​mathieucarbou`](https://github.com/mathieucarbou) in [mathieucarbou/license-maven-plugin#1078](https://redirect.github.com/mathieucarbou/license-maven-plugin/pull/1078)
>
> **Full Changelog**: <mathieucarbou/license-maven-plugin@v5.1.0...v5.1.1>
>
> v5.1.0
> ------
>
> What's Changed
> --------------
>
> * Bump com.google.guava:guava from 33.4.0-jre to 33.4.5-jre by [`@​dependabot`](https://github.com/dependabot)[bot] in [mathieucarbou/license-maven-plugin#922](https://redirect.github.com/mathieucarbou/license-maven-plugin/pull/922)
> * Bump com.google.guava:guava from 33.4.5-jre to 33.4.6-jre by [`@​dependabot`](https://github.com/dependabot)[bot] in [mathieucarbou/license-maven-plugin#924](https://redirect.github.com/mathieucarbou/license-maven-plugin/pull/924)
> * Bump surefire.version from 3.5.2 to 3.5.3 by [`@​dependabot`](https://github.com/dependabot)[bot] in [mathieucarbou/license-maven-plugin#925](https://redirect.github.com/mathieucarbou/license-maven-plugin/pull/925)
> * Bump com.puppycrawl.tools:checkstyle from 10.21.4 to 10.22.0 by [`@​dependabot`](https://github.com/dependabot)[bot] in [mathieucarbou/license-maven-plugin#927](https://redirect.github.com/mathieucarbou/license-maven-plugin/pull/927)
> * Bump org.codehaus.mojo:extra-enforcer-rules from 1.9.0 to 1.10.0 by [`@​dependabot`](https://github.com/dependabot)[bot] in [mathieucarbou/license-maven-plugin#928](https://redirect.github.com/mathieucarbou/license-maven-plugin/pull/928)
> * Bump com.puppycrawl.tools:checkstyle from 10.22.0 to 10.23.0 by [`@​dependabot`](https://github.com/dependabot)[bot] in [mathieucarbou/license-maven-plugin#929](https://redirect.github.com/mathieucarbou/license-maven-plugin/pull/929)
> * Bump org.jacoco:jacoco-maven-plugin from 0.8.12 to 0.8.13 by [`@​dependabot`](https://github.com/dependabot)[bot] in [mathieucarbou/license-maven-plugin#930](https://redirect.github.com/mathieucarbou/license-maven-plugin/pull/930)
> * Bump org.mockito:mockito-bom from 5.16.1 to 5.17.0 by [`@​dependabot`](https://github.com/dependabot)[bot] in [mathieucarbou/license-maven-plugin#931](https://redirect.github.com/mathieucarbou/license-maven-plugin/pull/931)
> * Bump com.google.guava:guava from 33.4.6-jre to 33.4.7-jre by [`@​dependabot`](https://github.com/dependabot)[bot] in [mathieucarbou/license-maven-plugin#932](https://redirect.github.com/mathieucarbou/license-maven-plugin/pull/932)
> * Bump junit.version from 5.12.1 to 5.12.2 by [`@​dependabot`](https://github.com/dependabot)[bot] in [mathieucarbou/license-maven-plugin#933](https://redirect.github.com/mathieucarbou/license-maven-plugin/pull/933)
> * Bump com.google.code.gson:gson from 2.12.1 to 2.13.0 by [`@​dependabot`](https://github.com/dependabot)[bot] in [mathieucarbou/license-maven-plugin#934](https://redirect.github.com/mathieucarbou/license-maven-plugin/pull/934)
> * Bump com.google.guava:guava from 33.4.7-jre to 33.4.8-jre by [`@​dependabot`](https://github.com/dependabot)[bot] in [mathieucarbou/license-maven-plugin#935](https://redirect.github.com/mathieucarbou/license-maven-plugin/pull/935)
> * Bump fr.jcgay.maven:maven-profiler from 3.2 to 3.3 by [`@​dependabot`](https://github.com/dependabot)[bot] in [mathieucarbou/license-maven-plugin#937](https://redirect.github.com/mathieucarbou/license-maven-plugin/pull/937)
> * Bump com.google.code.gson:gson from 2.13.0 to 2.13.1 by [`@​dependabot`](https://github.com/dependabot)[bot] in [mathieucarbou/license-maven-plugin#936](https://redirect.github.com/mathieucarbou/license-maven-plugin/pull/936)
> * Bump com.puppycrawl.tools:checkstyle from 10.23.0 to 10.23.1 by [`@​dependabot`](https://github.com/dependabot)[bot] in [mathieucarbou/license-maven-plugin#938](https://redirect.github.com/mathieucarbou/license-maven-plugin/pull/938)
> * Bump org.mockito:mockito-bom from 5.17.0 to 5.18.0 by [`@​dependabot`](https://github.com/dependabot)[bot] in [mathieucarbou/license-maven-plugin#939](https://redirect.github.com/mathieucarbou/license-maven-plugin/pull/939)
> * Bump com.puppycrawl.tools:checkstyle from 10.23.1 to 10.24.0 by [`@​dependabot`](https://github.com/dependabot)[bot] in [mathieucarbou/license-maven-plugin#940](https://redirect.github.com/mathieucarbou/license-maven-plugin/pull/940)
> * Bump groovy.version from 4.0.26 to 4.0.27 by [`@​dependabot`](https://github.com/dependabot)[bot] in [mathieucarbou/license-maven-plugin#942](https://redirect.github.com/mathieucarbou/license-maven-plugin/pull/942)
> * Bump org.eclipse.jgit:org.eclipse.jgit from 6.10.0.202406032230-r to 6.10.1.202505221210-r in /license-maven-plugin-git in the maven group across 1 directory by [`@​dependabot`](https://github.com/dependabot)[bot] in [mathieucarbou/license-maven-plugin#943](https://redirect.github.com/mathieucarbou/license-maven-plugin/pull/943)
> * Bump junit.version from 5.12.2 to 5.13.0 by [`@​dependabot`](https://github.com/dependabot)[bot] in [mathieucarbou/license-maven-plugin#944](https://redirect.github.com/mathieucarbou/license-maven-plugin/pull/944)
> * Bump com.puppycrawl.tools:checkstyle from 10.24.0 to 10.25.0 by [`@​dependabot`](https://github.com/dependabot)[bot] in [mathieucarbou/license-maven-plugin#947](https://redirect.github.com/mathieucarbou/license-maven-plugin/pull/947)
> * Bump org.apache.maven.plugins:maven-clean-plugin from 3.4.1 to 3.5.0 by [`@​dependabot`](https://github.com/dependabot)[bot] in [mathieucarbou/license-maven-plugin#946](https://redirect.github.com/mathieucarbou/license-maven-plugin/pull/946)
> * Bump junit.version from 5.13.0 to 5.13.1 by [`@​dependabot`](https://github.com/dependabot)[bot] in [mathieucarbou/license-maven-plugin#949](https://redirect.github.com/mathieucarbou/license-maven-plugin/pull/949)
> * Bump com.puppycrawl.tools:checkstyle from 10.25.0 to 10.25.1 by [`@​dependabot`](https://github.com/dependabot)[bot] in [mathieucarbou/license-maven-plugin#951](https://redirect.github.com/mathieucarbou/license-maven-plugin/pull/951)
> * Bump junit.version from 5.13.1 to 5.13.2 by [`@​dependabot`](https://github.com/dependabot)[bot] in [mathieucarbou/license-maven-plugin#952](https://redirect.github.com/mathieucarbou/license-maven-plugin/pull/952)
> * Bump com.puppycrawl.tools:checkstyle from 10.25.1 to 10.26.0 by [`@​dependabot`](https://github.com/dependabot)[bot] in [mathieucarbou/license-maven-plugin#953](https://redirect.github.com/mathieucarbou/license-maven-plugin/pull/953)
> * Bump org.apache.maven.plugins:maven-invoker-plugin from 3.9.0 to 3.9.1 by [`@​dependabot`](https://github.com/dependabot)[bot] in [mathieucarbou/license-maven-plugin#955](https://redirect.github.com/mathieucarbou/license-maven-plugin/pull/955)
> * Bump com.puppycrawl.tools:checkstyle from 10.26.0 to 10.26.1 by [`@​dependabot`](https://github.com/dependabot)[bot] in [mathieucarbou/license-maven-plugin#954](https://redirect.github.com/mathieucarbou/license-maven-plugin/pull/954)
> * Bump maven.version from 3.9.9 to 3.9.10 by [`@​dependabot`](https://github.com/dependabot)[bot] in [mathieucarbou/license-maven-plugin#948](https://redirect.github.com/mathieucarbou/license-maven-plugin/pull/948)
> * Bump org.apache.maven.plugins:maven-gpg-plugin from 3.2.7 to 3.2.8 by [`@​dependabot`](https://github.com/dependabot)[bot] in [mathieucarbou/license-maven-plugin#958](https://redirect.github.com/mathieucarbou/license-maven-plugin/pull/958)
> * Bump org.apache.maven.plugins:maven-enforcer-plugin from 3.5.0 to 3.6.0 by [`@​dependabot`](https://github.com/dependabot)[bot] in [mathieucarbou/license-maven-plugin#957](https://redirect.github.com/mathieucarbou/license-maven-plugin/pull/957)
> * Build updates by [`@​hazendaz`](https://github.com/hazendaz) in [mathieucarbou/license-maven-plugin#945](https://redirect.github.com/mathieucarbou/license-maven-plugin/pull/945)
> * Bump junit.version from 5.13.2 to 5.13.3 by [`@​dependabot`](https://github.com/dependabot)[bot] in [mathieucarbou/license-maven-plugin#959](https://redirect.github.com/mathieucarbou/license-maven-plugin/pull/959)
> * Bump maven.version from 3.9.10 to 3.9.11 by [`@​dependabot`](https://github.com/dependabot)[bot] in [mathieucarbou/license-maven-plugin#960](https://redirect.github.com/mathieucarbou/license-maven-plugin/pull/960)
> * Bump org.apache.maven.plugins:maven-enforcer-plugin from 3.6.0 to 3.6.1 by [`@​dependabot`](https://github.com/dependabot)[bot] in [mathieucarbou/license-maven-plugin#961](https://redirect.github.com/mathieucarbou/license-maven-plugin/pull/961)
> * Bump junit.version from 5.13.3 to 5.13.4 by [`@​dependabot`](https://github.com/dependabot)[bot] in [mathieucarbou/license-maven-plugin#962](https://redirect.github.com/mathieucarbou/license-maven-plugin/pull/962)
> * Bump groovy.version from 4.0.27 to 4.0.28 by [`@​dependabot`](https://github.com/dependabot)[bot] in [mathieucarbou/license-maven-plugin#963](https://redirect.github.com/mathieucarbou/license-maven-plugin/pull/963)
> * Bump org.assertj:assertj-core from 3.27.3 to 3.27.4 by [`@​dependabot`](https://github.com/dependabot)[bot] in [mathieucarbou/license-maven-plugin#965](https://redirect.github.com/mathieucarbou/license-maven-plugin/pull/965)
> * Bump org.mockito:mockito-bom from 5.18.0 to 5.19.0 by [`@​dependabot`](https://github.com/dependabot)[bot] in [mathieucarbou/license-maven-plugin#966](https://redirect.github.com/mathieucarbou/license-maven-plugin/pull/966)
> * Bump org.apache.maven.plugins:maven-javadoc-plugin from 3.11.2 to 3.11.3 by [`@​dependabot`](https://github.com/dependabot)[bot] in [mathieucarbou/license-maven-plugin#967](https://redirect.github.com/mathieucarbou/license-maven-plugin/pull/967)
> * Bump groovy.version from 4.0.28 to 5.0.0 by [`@​dependabot`](https://github.com/dependabot)[bot] in [mathieucarbou/license-maven-plugin#968](https://redirect.github.com/mathieucarbou/license-maven-plugin/pull/968)

... (truncated)


Commits

* [`602a083`](mathieucarbou/license-maven-plugin@602a083) [maven-release-plugin] prepare release v5.1.1
* [`590c91f`](mathieucarbou/license-maven-plugin@590c91f) Merge pull request [#1078](https://redirect.github.com/mathieucarbou/license-maven-plugin/issues/1078) from mathieucarbou/revert-1077-fix/git
* [`b485d43`](mathieucarbou/license-maven-plugin@b485d43) Revert "fix(git): follow renames across merges in copyright creation year (#b...
* [`ce2cb81`](mathieucarbou/license-maven-plugin@ce2cb81) Rolback to 5.0.0 for now
* [`d0e644e`](mathieucarbou/license-maven-plugin@d0e644e) Doc update
* [`f80e1b7`](mathieucarbou/license-maven-plugin@f80e1b7) [maven-release-plugin] prepare for next development iteration
* [`f26d4bd`](mathieucarbou/license-maven-plugin@f26d4bd) [maven-release-plugin] prepare release v5.1.0
* [`6ca1342`](mathieucarbou/license-maven-plugin@6ca1342) Fix release process
* [`a082fc1`](mathieucarbou/license-maven-plugin@a082fc1) [maven-release-plugin] rollback the release of v5.1.0
* [`7049b92`](mathieucarbou/license-maven-plugin@7049b92) Fix release process
* Additional commits viewable in [compare view](mathieucarbou/license-maven-plugin@v5.0.0...v5.1.1)
  
[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility\_score?dependency-name=com.mycila:license-maven-plugin&package-manager=maven&previous-version=5.0.0&new-version=5.1.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
Dependabot commands and options
  
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot show  ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@mathieucarbou mathieucarbou

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mathieucarbou