Skip to content

fix(specs): add facetFilters back to recommend fallbackParameters - #6727

Merged
Fluf22 merged 1 commit into
mainfrom
fix/recommend-fallback-facetfilters
Jul 15, 2026
Merged

Fluf22 merged 1 commit into
mainfrom
fix/recommend-fallback-facetfilters

Conversation

@raed667

@raed667 raed667 commented Jul 15, 2026 •

Copy link
Copy Markdown
Contributor

🧭 What and Why

Fixes #6725

#6604 dropped facetFilters from both queryParameters and fallbackParameters on Recommend. Dropping it from queryParameters was right, since the API overrides it there. But facetFilters is a supported fallbackParameters value, and the fallback docs tell you to use it. It shouldn't have left the fallback schema.

This adds it back to fallbackParams only. I put it on an inline object the same way #6604 kept enableRules, so it lands on the fallback schema without leaking back into queryParameters (both share baseRecommendSearchParams).

The three other params #6604 removed stay removed: ranking, enableABTest, and enableRules (from fallback). The API ignores those and applies its own values, so listing them was misleading. numericFilters, the other documented fallback param, was never touched.

Changes included:

  • Add facetFilters to fallbackParams (inline, not on the shared base).
  • Add facetFilters to the getRecommendations "all parameters" CTS test, under fallbackParameters.

🧪 Test

yarn cli build specs recommend passes lint and validation. Checked the bundled output: facetFilters shows up under fallbackParams and stays absent from recommendSearchParams.

facetFilters was removed from both queryParameters and fallbackParameters
in #6604. While it's correctly overridden by the API in queryParameters,
it's a valid parameter for fallbackParameters as documented.

This adds it back to fallbackParameters only, without re-adding it to
queryParameters.

Fixes #6725
@raed667
raed667 requested a review from a team as a code owner July 15, 2026 05:29
@algolia-api-clients-automation-bot

algolia-api-clients-automation-bot Bot commented Jul 15, 2026 •

Copy link
Copy Markdown
Contributor

āœ”ļø Code generated!

Name Link
šŸŖ“ Triggered by 6a40518744579c5776f4de54a990ebfe63d7b948
šŸƒ Generated commit 4a0456389d38d33cb78f9300e42c6bb7903ded6f
🌲 Generated branch generated/fix/recommend-fallback-facetfilters
šŸ“Š Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
php 2475
javascript 2285
csharp 1886
go 1784
python 1228
java 1068
ruby 985
swift 839
scala 23

@Fluf22
Fluf22 merged commit ac68c1a into main Jul 15, 2026
36 checks passed
@Fluf22
Fluf22 deleted the fix/recommend-fallback-facetfilters branch July 15, 2026 06:18
algolia-api-clients-automation-bot Bot added a commit that referenced this pull request Jul 15, 2026
) (generated) [skip ci]

Co-authored-by: Raed <raed.chammam@algolia.com>
algolia-api-clients-automation-bot Bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Jul 15, 2026
…nerated)

algolia/api-clients-automation#6727

Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com>
Co-authored-by: Raed <raed.chammam@algolia.com>
algolia-api-clients-automation-bot Bot added a commit to algolia/algoliasearch-client-dart that referenced this pull request Jul 15, 2026
…nerated)

algolia/api-clients-automation#6727

Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com>
Co-authored-by: Raed <raed.chammam@algolia.com>
algolia-api-clients-automation-bot Bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Jul 15, 2026
…nerated)

algolia/api-clients-automation#6727

Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com>
Co-authored-by: Raed <raed.chammam@algolia.com>
algolia-api-clients-automation-bot Bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Jul 15, 2026
…nerated)

algolia/api-clients-automation#6727

Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com>
Co-authored-by: Raed <raed.chammam@algolia.com>
algolia-api-clients-automation-bot Bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Jul 15, 2026
…nerated)

algolia/api-clients-automation#6727

Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com>
Co-authored-by: Raed <raed.chammam@algolia.com>
algolia-api-clients-automation-bot Bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Jul 15, 2026
…nerated)

algolia/api-clients-automation#6727

Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com>
Co-authored-by: Raed <raed.chammam@algolia.com>
algolia-api-clients-automation-bot Bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Jul 15, 2026
…nerated)

algolia/api-clients-automation#6727

Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com>
Co-authored-by: Raed <raed.chammam@algolia.com>
algolia-api-clients-automation-bot Bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Jul 15, 2026
…nerated)

algolia/api-clients-automation#6727

Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com>
Co-authored-by: Raed <raed.chammam@algolia.com>
algolia-api-clients-automation-bot Bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Jul 15, 2026
…nerated)

algolia/api-clients-automation#6727

Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com>
Co-authored-by: Raed <raed.chammam@algolia.com>
algolia-api-clients-automation-bot Bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Jul 15, 2026
…nerated)

algolia/api-clients-automation#6727

Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com>
Co-authored-by: Raed <raed.chammam@algolia.com>
algolia-api-clients-automation-bot Bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Jul 15, 2026
…nerated)

algolia/api-clients-automation#6727

Co-authored-by: algolia-api-clients-automation-bot[bot] <288895823+algolia-api-clients-automation-bot[bot]@users.noreply.github.com>
Co-authored-by: Raed <raed.chammam@algolia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug]: Incorrectly removed facetFilters from fallbackParameters

2 participants