Skip to content

Fix: Stabilize ReferenceConfigTest by Disabling Metrics Initialization and Ensuring Test Isolation - #15787

Merged
RainYuY merged 1 commit into
apache:3.3from
Anshul-creator:fix-ReferenceConfigTest
Nov 26, 2025
Merged

RainYuY merged 1 commit into
apache:3.3from
Anshul-creator:fix-ReferenceConfigTest

Conversation

@Anshul-creator

@Anshul-creator Anshul-creator commented Nov 21, 2025 •

Copy link
Copy Markdown
Contributor

What is the purpose of the change?

This PR stabilizes all ReferenceConfig tests that were intermittently failing under randomized execution orders (NonDex):

  • testCreateInvokerForLocalRefer
  • testClassLoader
  • testMultipleRegistryForRemoteRefer
  • testCreateInvokerForRemoteRefer
  • testCreateInvokerWithRemoteUrlForRemoteRefer
  • testCreateInvokerWithRegistryUrlForRemoteRefer
  • testGenericAndInterfaceConflicts
  • testDifferentClassLoader
  • testAppendConfig
  • test1ReferenceRetry
  • test2ReferenceRetry

All of these tests were affected by nondeterministic behavior triggered by Micrometer’s composite meter registry during Dubbo bootstrap, even though the tests do not depend on metrics.

Root Cause

These failures are identical to previously fixed issues in:

Those earlier PRs addressed flakiness caused by Micrometer’s CompositeMeterRegistry being initialized during DubboBootstrap.initialize(), leading to intermittent ArrayIndexOutOfBoundsException under NonDex seeds.

ReferenceConfigTest suffers from the exact same root cause, and the same fix (inline disabling of metrics + SysProps isolation) resolves the issue.

Changes Made

  • Disabled the metrics subsystem at the beginning of each test
  • Cleared all system properties using SysProps.clear() in both @BeforeEach and @AfterEach.
  • Ensured consistent test isolation by resetting framework state

Verification

You can try running the following snippet of code from the dubbo repo root, on both pre-fix and post-fix code

./mvnw -q -pl dubbo-config/dubbo-config-api \
  edu.illinois:nondex-maven-plugin:2.2.1:nondex \
  -DnondexRuns=20

The tests should fail intermittently on the pre-fix version, but pass consistently across all seeds on the post-fix version.
NonDex run logs will be available under the dubbo-config/dubbo-config-api/.nondex directory.

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@codecov-commenter

codecov-commenter commented Nov 21, 2025 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.79%. Comparing base (9b32dc1) to head (c878fd6).

Additional details and impacted files
@@             Coverage Diff              @@
##                3.3   #15787      +/-   ##
============================================
+ Coverage     60.76%   60.79%   +0.02%     
+ Complexity    11698    11697       -1     
============================================
  Files          1938     1938              
  Lines         88646    88646              
  Branches      13379    13379              
============================================
+ Hits          53868    53889      +21     
+ Misses        29250    29231      -19     
+ Partials       5528     5526       -2     
Flag Coverage Δ
integration-tests-java21 32.37% <ø> (+<0.01%) ⬆️
integration-tests-java8 32.40% <ø> (-0.04%) ⬇️
samples-tests-java21 32.02% <ø> (-0.04%) ⬇️
samples-tests-java8 29.58% <ø> (-0.12%) ⬇️
unit-tests-java11 59.07% <ø> (-0.01%) ⬇️
unit-tests-java17 58.55% <ø> (ø)
unit-tests-java21 58.58% <ø> (+<0.01%) ⬆️
unit-tests-java25 58.52% <ø> (-0.02%) ⬇️
unit-tests-java8 59.08% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zrlw zrlw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RainYuY
RainYuY merged commit 7b48706 into apache:3.3 Nov 26, 2025
@Anshul-creator
Anshul-creator deleted the fix-ReferenceConfigTest branch November 27, 2025 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants