Repository navigation
Fix: Stabilize ApplicationConfigTest by Disabling Metrics Initialization and Ensuring Test Isolation - #15791
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.3 #15791 +/- ##
============================================
+ Coverage 60.76% 60.78% +0.02%
+ Complexity 11698 11690 -8
============================================
Files 1938 1938
Lines 88646 88646
Branches 13379 13379
============================================
+ Hits 53868 53886 +18
+ Misses 29250 29237 -13
+ Partials 5528 5523 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4 tasks done
RainYuY
approved these changes
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change?
This PR stabilizes several tests in
ApplicationConfigTestthat were intermittently failing under randomized execution orders (NonDex):testOverrideEmptyConfigtestOverrideConfigByIdtestOverrideConfigByNametestLoadConfigtestOverrideConfigConvertCasetestDefaultValueAll of these tests trigger
DubboBootstrap.initialize()which unintentionally initializes the metrics subsystem. Since these tests do not depend on metrics, metrics initialization introduces nondeterministic failures unrelated to application configuration logic.Root Cause
These failures are identical to previously fixed issues in:
ExporterSideConfigUrlTestby disabling metrics initialization during URL export #15778MethodConfigTestby disabling metrics initialization to avoid Micrometer nondeterminism #15782ServiceConfigTestby isolating system properties and cached state #15785Those PRs addressed flakiness caused by Micrometer’s
CompositeMeterRegistrybeing initialized duringDubboBootstrap.initialize(), which, under certain NonDex randomized execution orders, can throw anArrayIndexOutOfBoundsExceptionfrom an internalIdentityHashMapiterator.ApplicationConfigTestsuffers from the same root cause, and the same fix resolves the issue.Changes Made
SysProps.clear()in the lifecycle hooks to avoid cross-test pollution.DubboBootstrap.reset()to ensure isolation between tests.Verification
You can try running the following snippet of code from the dubbo repo root, on both pre-fix and post-fix code
The tests should fail intermittently on the pre-fix version, but pass consistently across all seeds on the post-fix version.
NonDex run logs will be available under the
dubbo-config/dubbo-config-api/.nondexdirectory.Checklist