🔥 Jadwal & Hasil: astral sh/ruff/pull/

charliermarsh · 2026-10-19T18:26:42Z

Summary

We give ASCII identifiers a dedicated path, avoiding Unicode bookkeeping and checking string prefixes only when a one- or two-letter name reaches a quote. Both paths share the existing batched ASCII scanner, preserving fast scanning for Unicode names with long ASCII suffixes.

Stacked on #29463 to measure the incremental improvement. CodSpeed reports 6.6–9.8% greater efficiency across all five lexer benchmarks, with no reported regressions. We preserve the existing scanner and add no inlining attributes or unsafe code.

astral-sh-bot · 2026-10-19T18:31:12Z

Memory usage report

Memory usage unchanged ✅

astral-sh-bot · 2026-10-19T18:31:54Z

`ecosystem-analyzer` results

No diagnostic changes detected ✅

Full report with detailed diff (timing results)

astral-sh-bot · 2026-10-19T18:51:40Z

`ruff-ecosystem` results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

codspeed · 2026-10-19T19:10:17Z

Merging this PR will improve performance by 8.08%

1 warning

⚠️ Base and head ran on different runner types

Some benchmarks with significant performance changes were compared across different runner types, so the changes might not come from the code. Run base and head on the same runner type, or use CodSpeed Macro Runners for more stable results.

Learn more about Macro Runners

Open the report in CodSpeed to investigate

⚡ 5 improved benchmarks
✅ 257 untouched benchmarks
⏩ 14 skipped benchmarks¹

Performance Changes

	Mode	Benchmark	`BASE`	`HEAD`	Efficiency
⚡	CPU Simulation	`lexer[pydantic/types.py]`	649.9 µs	594.9 µs	+9.24%
⚡	CPU Simulation	`lexer[numpy/ctypeslib.py]`	290 µs	265.9 µs	+9.1%
⚡	CPU Simulation	`lexer[large/dataset.py]`	1.4 ms	1.3 ms	+8.93%
⚡	CPU Simulation	`lexer[unicode/pypinyin.py]`	98.8 µs	92.3 µs	+7.04%
⚡	CPU Simulation	`lexer[numpy/globals.py]`	39.5 µs	37.2 µs	+6.11%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.

_{Comparing charlie/ruff-parser-hillclimb-next (cc8580c) with charlie/ruff-ascii-identifiers (6818c90)}

14 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

MichaReiser

I don't know why but GitHub does not show me the approve button 😆 but consider this approved

MichaReiser · 2026-10-19T21:35:05Z

                self.state = State::Other;
-
-                identifier
+                self.lex_unicode_identifier()


Is it an issue that we now assign the state before lexing the identifier?

MichaReiser · 2026-10-19T21:37:41Z


+    /// Finishes an identifier after consuming a non-ASCII identifier character.
+    fn lex_unicode_identifier(&mut self) -> TokenKind {
+        let ascii_len = ascii_identifier_prefix_len(self.cursor.rest().as_bytes());


Is skipping ascii caracters after a non-ASCII character worth it? Is the assumption here that a non-ASCII character is commonly followed by a long ASCII only sequence. I'm not sure this holds true and is also not something we do for unicode characters in the middle of a word.

MichaReiser · 2026-10-19T21:39:03Z

+                if self.cursor.eat_if(is_xid_continue).is_some() {
+                    return self.lex_unicode_identifier();
+                }


Could we avoid starting over if there's a non ascii character? Seems a bit wasteful to throw away what we already lexed.

MichaReiser · 2026-10-19T21:41:47Z

-            self.current_flags |= TokenFlags::NON_ASCII_IDENTIFIER;
-            return TokenKind::Identifier;
+        match bytes.get(ascii_len) {
+            Some(quote) if ascii_len <= 1 && matches!(quote, b'\'' | b'"') => {


Suggested change

Some(quote) if ascii_len <= 1 && matches!(quote, b'\'' | b'"') => {

Some(b'\'' | b'"') if ascii_len <= 1 => {

astral-automations-bot · 2026-10-23T17:49:58Z

Memory usage report

Memory usage unchanged ✅

Results for cc8580c · Workflow run

astral-automations-bot · 2026-10-23T17:51:02Z

`ecosystem-analyzer` results

No diagnostic changes detected ✅

Flaky changes detected. This PR summary excludes flaky changes; see the HTML report for details.

Full report with detailed diff · Timing results

Results for cc8580c · Workflow run

astral-automations-bot · 2026-10-23T17:52:07Z

`ruff-ecosystem` results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

Results for cc8580c · Workflow run

This PR contains the following updates: | Package | Type | Update | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---|---|---| | [DavidAnson/markdownlint-cli2](https://github.com/DavidAnson/markdownlint-cli2) | repository | minor | `v0.23.3` → `v0.24.0` | ![age](https://developer.mend.io/api/mc/badges/age/github-tags/DavidAnson%2fmarkdownlint-cli2/v0.24.0?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/github-tags/DavidAnson%2fmarkdownlint-cli2/v0.23.3/v0.24.0?slim=true) | | [ruff](https://docs.astral.sh/ruff) ([source](https://github.com/astral-sh/ruff), [changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md)) | dependency-groups | patch | `==0.17.1` → `==0.17.3` | ![age](https://developer.mend.io/api/mc/badges/age/pypi/ruff/0.17.3?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/ruff/0.17.1/0.17.3?slim=true) | Note: The `pre-commit` manager in Renovate is not supported by the `pre-commit` maintainers or community. Please do not report any problems there, instead [create a Discussion in the Renovate repository](https://github.com/renovatebot/renovate/discussions/new) if you have any questions. --- ### Release Notes <details> <summary>DavidAnson/markdownlint-cli2</summary> ### [`v0.24.0`](DavidAnson/markdownlint-cli2@v0.23.3...v0.24.0) [Compare Source](DavidAnson/markdownlint-cli2@v0.23.3...v0.24.0) </details> <details> <summary>astral-sh/ruff (ruff)</summary> ### [`v0.17.3`](https://github.com/astral-sh/ruff/blob/HEAD/CHANGELOG.md#0173) [Compare Source](astral-sh/ruff@0.17.2...0.17.3) Released on 2026-10-26. ##### Preview features - \[`suspicious`] Add `shared-clock-mock` ([#29074](astral-sh/ruff#29074)) ##### Bug fixes - \[`pyupgrade`] Avoid incorrect conversions to f-strings (`UP032`) ([#25485](astral-sh/ruff#25485)) ##### Performance - Buffer stdout in `ruff format` ([#29631](astral-sh/ruff#29631)) - Specialize ASCII identifier lexing ([#29503](astral-sh/ruff#29503)) - Speed up identifier and keyword lexing ([#29463](astral-sh/ruff#29463)) ##### Documentation - \[`flake8-bandit`] Describe what the rule actually checks for `httpx` (`S113`) ([#27936](astral-sh/ruff#27936)) ##### Contributors - [@itsvedantkumar](https://github.com/itsvedantkumar) - [@charliermarsh](https://github.com/charliermarsh) - [@anishgirianish](https://github.com/anishgirianish) ### [`v0.17.2`](https://github.com/astral-sh/ruff/blob/HEAD/CHANGELOG.md#0172) [Compare Source](astral-sh/ruff@0.17.1...0.17.2) Released on 2026-10-22. ##### Preview features - \[`complexity`] Add `unnecessary-regular-expression-compile` ([#25533](astral-sh/ruff#25533)) ##### Bug fixes - Avoid syntax errors for type variables with starred constraints (`UP040`, `UP046`, `UP047`, `RUF053`) ([#28362](astral-sh/ruff#28362)) - \[`pydocstyle`] Treat backslash-escaped `*args` and `**kwargs` as documented (`D417`) ([#29536](astral-sh/ruff#29536)) - \[`pylint`] Avoid false positive on starred elements (`PLE0643`) ([#29483](astral-sh/ruff#29483)) - \[`pylint`] Mark fixes unsafe when deleting comments (`PLR5501`, `PLW0120`) ([#29414](astral-sh/ruff#29414)) - \[`pyupgrade`] Mark fix unsafe when deleting comments (`UP035`) ([#29413](astral-sh/ruff#29413)) ##### Performance - Avoid intermediate names in lint name resolution ([#29506](astral-sh/ruff#29506)) - Prefilter bidirectional Unicode checks by UTF-8 leading bytes ([#29561](astral-sh/ruff#29561)) - Share postfix parsing and reduce expression copies ([#29480](astral-sh/ruff#29480)) ##### Configuration - \[`pylint`] Add a configurable allowlist for `magic-value-comparison` (`PLR2004`) ([#18961](astral-sh/ruff#18961)) ##### Documentation - Clarify documentation and correct stale guidance ([#29374](astral-sh/ruff#29374)) - \[`pyupgrade`] Remove mentions of variance related to fix safety (`UP040`, `UP047`) ([#29592](astral-sh/ruff#29592)) ##### Contributors - [@fixfon](https://github.com/fixfon) - [@MichaReiser](https://github.com/MichaReiser) - [@zaniebot](https://github.com/zaniebot) - [@FrancescoPezzella](https://github.com/FrancescoPezzella) - [@anishgirianish](https://github.com/anishgirianish) - [@rajveer3x](https://github.com/rajveer3x) - [@charliermarsh](https://github.com/charliermarsh) - [@LckyLike](https://github.com/LckyLke) - [@DaniBodor](https://github.com/DaniBodor) </details> --- ### Configuration 📅 **Schedule**: (in timezone America/Denver) - Branch creation - Between 02:00 AM and 06:59 AM, only on Tuesday (`* 2-6 * * 2`) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.lichtenwalter.site/rlichten/dir2text/pulls/100

charliermarsh temporarily deployed to automations October 19, 2026 18:27 — with GitHub Actions Inactive

charliermarsh added this pull request to stack #29499 October 19, 2026 19:29

charliermarsh force-pushed the charlie/ruff-parser-hillclimb-next branch from dee63d0 to 9d1d502 Compare October 19, 2026 20:35

charliermarsh temporarily deployed to automations October 19, 2026 20:35 — with GitHub Actions Inactive

charliermarsh marked this pull request as ready for review October 19, 2026 21:05

charliermarsh requested review from MichaReiser and dhruvmanila as code owners October 19, 2026 21:05

charliermarsh closed this Oct 19, 2026

MichaReiser reviewed Oct 19, 2026

View reviewed changes

charliermarsh reopened this Oct 19, 2026

charliermarsh temporarily deployed to automations October 19, 2026 21:57 — with GitHub Actions Inactive

charliermarsh force-pushed the charlie/ruff-parser-hillclimb-next branch from 9d1d502 to a52df1b Compare October 20, 2026 00:59

charliermarsh temporarily deployed to automations October 20, 2026 01:00 — with GitHub Actions Inactive

charliermarsh temporarily deployed to automations October 20, 2026 01:06 — with GitHub Actions Inactive

charliermarsh added 2 commits October 23, 2026 13:44

Specialize ASCII identifier lexing

76daac9

Clarify Unicode identifier continuation

cc8580c

charliermarsh force-pushed the charlie/ruff-parser-hillclimb-next branch from 7460521 to cc8580c Compare October 23, 2026 17:45

charliermarsh temporarily deployed to automations October 23, 2026 17:45 — with GitHub Actions Inactive

charliermarsh merged commit e330485 into main Oct 23, 2026
101 of 137 checks passed

charliermarsh deleted the charlie/ruff-parser-hillclimb-next branch October 23, 2026 17:58

ntBre added performance Potential performance improvement parser Related to the parser labels Oct 23, 2026

BrewTestBot mentioned this pull request Oct 27, 2026

ruff 0.17.3 Homebrew/homebrew-core#321519

Merged

	Some(quote) if ascii_len <= 1 && matches!(quote, b'\'' \| b'"') => {
	Some(b'\'' \| b'"') if ascii_len <= 1 => {

Conversation

charliermarsh commented Oct 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

astral-sh-bot Bot commented Oct 19, 2026

Memory usage report

Uh oh!

astral-sh-bot Bot commented Oct 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ecosystem-analyzer results

Uh oh!

astral-sh-bot Bot commented Oct 19, 2026

ruff-ecosystem results

Linter (stable)

Linter (preview)

Formatter (stable)

Formatter (preview)

Uh oh!

codspeed Bot commented Oct 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will improve performance by 8.08%

Performance Changes

Footnotes

Uh oh!

MichaReiser left a comment

Choose a reason for hiding this comment

Uh oh!

MichaReiser Oct 19, 2026

Choose a reason for hiding this comment

Uh oh!

MichaReiser Oct 19, 2026

Choose a reason for hiding this comment

Uh oh!

MichaReiser Oct 19, 2026

Choose a reason for hiding this comment

Uh oh!

MichaReiser Oct 19, 2026

Choose a reason for hiding this comment

Uh oh!

astral-automations-bot Bot commented Oct 23, 2026

Memory usage report

Uh oh!

astral-automations-bot Bot commented Oct 23, 2026

ecosystem-analyzer results

Uh oh!

astral-automations-bot Bot commented Oct 23, 2026

ruff-ecosystem results

Linter (stable)

Linter (preview)

Formatter (stable)

Formatter (preview)

Uh oh!

Uh oh!

This branch was previously deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

charliermarsh commented Oct 19, 2026 •

edited

Loading

astral-sh-bot Bot commented Oct 19, 2026 •

edited

Loading

`ecosystem-analyzer` results

`ruff-ecosystem` results

codspeed Bot commented Oct 19, 2026 •

edited

Loading

`ecosystem-analyzer` results

`ruff-ecosystem` results