🔥 Jadwal & Hasil: astral sh/ruff/pull/

MichaReiser · 2026-10-19T19:18:31Z

Summary

Avoid constructing an intermediate UnqualifiedName when resolving imported names and builtin attributes. Building a UnqualifiedName copies all segments into an intermediate SmallVec, which we then copied over to the QualifiedName. This copying ends up being expensive, given that resolving is a very hot function.

This PR introduces a new QualifiedName::qualify method that allows qualifying an expression without going through UnqualifiedName.

I spend a good amount of time trying to share the loop unrolling with UnqualifiedName, but most of what I tried either required macros or const generics (which I both don't like), or introduced extra function calls (which hurt the UnqualifiedName path). For now, I decided to not spend more time on this and accept that this path does not unroll the attribute loop. We can spend more time on figuring out how to share the unrolling, if it shows up in profiles after this PR merges.

This improvement was found by codspeeds optimization bot.

Test Plan

Testing: Linter, AST, and semantic tests, Clippy, and scoped hooks passed.

astral-sh-bot · 2026-10-19T19:23:39Z

Memory usage report

Memory usage unchanged ✅

astral-sh-bot · 2026-10-19T19:24:04Z

`ecosystem-analyzer` results

No diagnostic changes detected ✅

Full report with detailed diff (timing results)

astral-sh-bot · 2026-10-19T19:42:18Z

`ruff-ecosystem` results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

codspeed · 2026-10-19T19:51:57Z

Merging this PR will improve performance by 8.03%

⚡ 6 improved benchmarks
✅ 238 untouched benchmarks
⏩ 10 skipped benchmarks¹

Performance Changes

	Mode	Benchmark	`BASE`	`HEAD`	Efficiency
⚡	Simulation	`linter/all-rules[large/dataset.py]`	38 ms	34 ms	+11.73%
⚡	Simulation	`linter/all-with-preview-rules[large/dataset.py]`	44.2 ms	40 ms	+10.36%
⚡	Simulation	`linter/default-rules[large/dataset.py]`	19 ms	17.6 ms	+7.65%
⚡	Simulation	`linter/default-rules[pydantic/types.py]`	9.7 ms	9.1 ms	+6.53%
⚡	Simulation	`linter/all-rules[pydantic/types.py]`	17.4 ms	16.4 ms	+6.19%
⚡	Simulation	`linter/all-with-preview-rules[pydantic/types.py]`	19.8 ms	18.7 ms	+5.85%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.

_{Comparing micha/ruff-qualified-name-resolution (1d04da3) with main (3e3f22d)}

10 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

MichaReiser · 2026-10-20T16:55:51Z

-                            .collect()
-                    };
-                Some(resolved)
+                if qualified_name.is_unresolved_import() {


This is the same as qualified_name.segments().first().copied() == Some(".")

This PR contains the following updates: | Package | Type | Update | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---|---|---| | [DavidAnson/markdownlint-cli2](https://github.com/DavidAnson/markdownlint-cli2) | repository | minor | `v0.23.3` → `v0.24.0` | ![age](https://developer.mend.io/api/mc/badges/age/github-tags/DavidAnson%2fmarkdownlint-cli2/v0.24.0?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/github-tags/DavidAnson%2fmarkdownlint-cli2/v0.23.3/v0.24.0?slim=true) | | [ruff](https://docs.astral.sh/ruff) ([source](https://github.com/astral-sh/ruff), [changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md)) | dependency-groups | patch | `==0.17.1` → `==0.17.3` | ![age](https://developer.mend.io/api/mc/badges/age/pypi/ruff/0.17.3?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/ruff/0.17.1/0.17.3?slim=true) | Note: The `pre-commit` manager in Renovate is not supported by the `pre-commit` maintainers or community. Please do not report any problems there, instead [create a Discussion in the Renovate repository](https://github.com/renovatebot/renovate/discussions/new) if you have any questions. --- ### Release Notes <details> <summary>DavidAnson/markdownlint-cli2</summary> ### [`v0.24.0`](DavidAnson/markdownlint-cli2@v0.23.3...v0.24.0) [Compare Source](DavidAnson/markdownlint-cli2@v0.23.3...v0.24.0) </details> <details> <summary>astral-sh/ruff (ruff)</summary> ### [`v0.17.3`](https://github.com/astral-sh/ruff/blob/HEAD/CHANGELOG.md#0173) [Compare Source](astral-sh/ruff@0.17.2...0.17.3) Released on 2026-10-26. ##### Preview features - \[`suspicious`] Add `shared-clock-mock` ([#29074](astral-sh/ruff#29074)) ##### Bug fixes - \[`pyupgrade`] Avoid incorrect conversions to f-strings (`UP032`) ([#25485](astral-sh/ruff#25485)) ##### Performance - Buffer stdout in `ruff format` ([#29631](astral-sh/ruff#29631)) - Specialize ASCII identifier lexing ([#29503](astral-sh/ruff#29503)) - Speed up identifier and keyword lexing ([#29463](astral-sh/ruff#29463)) ##### Documentation - \[`flake8-bandit`] Describe what the rule actually checks for `httpx` (`S113`) ([#27936](astral-sh/ruff#27936)) ##### Contributors - [@itsvedantkumar](https://github.com/itsvedantkumar) - [@charliermarsh](https://github.com/charliermarsh) - [@anishgirianish](https://github.com/anishgirianish) ### [`v0.17.2`](https://github.com/astral-sh/ruff/blob/HEAD/CHANGELOG.md#0172) [Compare Source](astral-sh/ruff@0.17.1...0.17.2) Released on 2026-10-22. ##### Preview features - \[`complexity`] Add `unnecessary-regular-expression-compile` ([#25533](astral-sh/ruff#25533)) ##### Bug fixes - Avoid syntax errors for type variables with starred constraints (`UP040`, `UP046`, `UP047`, `RUF053`) ([#28362](astral-sh/ruff#28362)) - \[`pydocstyle`] Treat backslash-escaped `*args` and `**kwargs` as documented (`D417`) ([#29536](astral-sh/ruff#29536)) - \[`pylint`] Avoid false positive on starred elements (`PLE0643`) ([#29483](astral-sh/ruff#29483)) - \[`pylint`] Mark fixes unsafe when deleting comments (`PLR5501`, `PLW0120`) ([#29414](astral-sh/ruff#29414)) - \[`pyupgrade`] Mark fix unsafe when deleting comments (`UP035`) ([#29413](astral-sh/ruff#29413)) ##### Performance - Avoid intermediate names in lint name resolution ([#29506](astral-sh/ruff#29506)) - Prefilter bidirectional Unicode checks by UTF-8 leading bytes ([#29561](astral-sh/ruff#29561)) - Share postfix parsing and reduce expression copies ([#29480](astral-sh/ruff#29480)) ##### Configuration - \[`pylint`] Add a configurable allowlist for `magic-value-comparison` (`PLR2004`) ([#18961](astral-sh/ruff#18961)) ##### Documentation - Clarify documentation and correct stale guidance ([#29374](astral-sh/ruff#29374)) - \[`pyupgrade`] Remove mentions of variance related to fix safety (`UP040`, `UP047`) ([#29592](astral-sh/ruff#29592)) ##### Contributors - [@fixfon](https://github.com/fixfon) - [@MichaReiser](https://github.com/MichaReiser) - [@zaniebot](https://github.com/zaniebot) - [@FrancescoPezzella](https://github.com/FrancescoPezzella) - [@anishgirianish](https://github.com/anishgirianish) - [@rajveer3x](https://github.com/rajveer3x) - [@charliermarsh](https://github.com/charliermarsh) - [@LckyLike](https://github.com/LckyLke) - [@DaniBodor](https://github.com/DaniBodor) </details> --- ### Configuration 📅 **Schedule**: (in timezone America/Denver) - Branch creation - Between 02:00 AM and 06:59 AM, only on Tuesday (`* 2-6 * * 2`) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.lichtenwalter.site/rlichten/dir2text/pulls/100

Avoid intermediate names in lint name resolution

c793ae8

MichaReiser added performance Potential performance improvement linter Related to the Ruff linter labels Oct 19, 2026

MichaReiser temporarily deployed to automations October 19, 2026 19:18 — with GitHub Actions Inactive

Group qualified name constructors

3f9743d

MichaReiser temporarily deployed to automations October 20, 2026 00:15 — with GitHub Actions Inactive

Simplify qualified name attribute construction

d9871be

MichaReiser temporarily deployed to automations October 20, 2026 04:32 — with GitHub Actions Inactive

Rename qualified name attribute helper to qualify

bc2d533

MichaReiser had a problem deploying to automations October 20, 2026 05:06 — with GitHub Actions Error

Clarify qualification of name expressions

1d04da3

MichaReiser temporarily deployed to automations October 20, 2026 05:11 — with GitHub Actions Inactive

MichaReiser commented Oct 20, 2026

View reviewed changes

MichaReiser marked this pull request as ready for review October 20, 2026 17:00

ntBre approved these changes Oct 20, 2026

View reviewed changes

MichaReiser merged commit 2983c7c into main Oct 20, 2026
75 checks passed

MichaReiser deleted the micha/ruff-qualified-name-resolution branch October 20, 2026 17:35

BrewTestBot mentioned this pull request Oct 22, 2026

ruff 0.17.2 Homebrew/homebrew-core#320513

Merged

Navigation Menu

Repository navigation

Avoid intermediate names in lint name resolution - #29506

Avoid intermediate names in lint name resolution#29506
MichaReiser merged 5 commits into
mainfrom
micha/ruff-qualified-name-resolution

MichaReiser commented Oct 19, 2026 •

edited

Loading

Uh oh!

astral-sh-bot Bot commented Oct 19, 2026

Uh oh!

astral-sh-bot Bot commented Oct 19, 2026 •

edited

Loading

Uh oh!

astral-sh-bot Bot commented Oct 19, 2026

Uh oh!

codspeed Bot commented Oct 19, 2026 •

edited

Loading

Uh oh!

MichaReiser Oct 20, 2026

Uh oh!

Uh oh!

This branch was previously deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

MichaReiser commented Oct 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test Plan

Uh oh!

astral-sh-bot Bot commented Oct 19, 2026

Memory usage report

Uh oh!

astral-sh-bot Bot commented Oct 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ecosystem-analyzer results

Uh oh!

astral-sh-bot Bot commented Oct 19, 2026

ruff-ecosystem results

Linter (stable)

Linter (preview)

Formatter (stable)

Formatter (preview)

Uh oh!

codspeed Bot commented Oct 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will improve performance by 8.03%

Performance Changes

Footnotes

Uh oh!

MichaReiser Oct 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This branch was previously deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

MichaReiser commented Oct 19, 2026 •

edited

Loading

astral-sh-bot Bot commented Oct 19, 2026 •

edited

Loading

`ecosystem-analyzer` results

`ruff-ecosystem` results

codspeed Bot commented Oct 19, 2026 •

edited

Loading