Repository navigation
fix: remove visible logs when not in debug mode - #930
Merged
Merged
Conversation
dlvhdr
marked this pull request as ready for review
July 8, 2026 18:47
dlvhdr
pushed a commit
that referenced
this pull request
Jul 10, 2026
…933) # Summary - [x] Closes issue #932 - [x] Closes #932 - [x] I have read the [Contributing](../CONTRIBUTING.md) and the strict [No-AI Policy](../AI_POLICY.md) guides. ## How Did You Test this Change? Built the fixed version and ran it in a temp dir with no git ## Images/Videos NA ## Notes Probably should have some tests for this running outside of a git repo, but I figure adding tests for all this stuff should just come in a separate PR.
|
Closed
tomatg1
added a commit
to tomatg1/gh-dash
that referenced
this pull request
Aug 14, 2026
The fork's "don't die outside a git repo" patch is gone: upstream fixed the same bug in a613ef7 (PR dlvhdr#933, from dlvhdr#930) and released it as v4.25.2. That hunk was the rebase's only conflict -- both sides had deleted the same stray log.Fatal -- so the fork's commit was dropped rather than resolved. The diagnosis stays in the notes; the patch doesn't. Also record what the no-AI policy means in practice: upstream's AI_POLICY.md is unchanged (last touched 2026-06-05) and the PR template still asks contributors to attest they've read it, so nothing here goes upstream as a patch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
How Did You Test this Change?
Images/Videos