Skip to content

fix: remove visible logs when not in debug mode - #930

Merged
dlvhdr merged 2 commits into
mainfrom
dlvhdr/remove-logs
Jul 8, 2026
Merged

dlvhdr merged 2 commits into
mainfrom
dlvhdr/remove-logs

Conversation

@dlvhdr

@dlvhdr dlvhdr commented Jul 8, 2026

Copy link
Copy Markdown
Owner

Summary

How Did You Test this Change?

Images/Videos

@dlvhdr
dlvhdr marked this pull request as ready for review July 8, 2026 18:47
@dlvhdr
dlvhdr merged commit e7a7f07 into main Jul 8, 2026
4 checks passed
@dlvhdr
dlvhdr deleted the dlvhdr/remove-logs branch July 8, 2026 19:01
Comment thread cmd/root.go Resolved
dlvhdr pushed a commit that referenced this pull request Jul 10, 2026
…933)

# Summary

- [x] Closes issue #932
- [x] Closes #932
- [x] I have read the [Contributing](../CONTRIBUTING.md) and the strict
[No-AI Policy](../AI_POLICY.md) guides.

## How Did You Test this Change?

Built the fixed version and ran it in a temp dir with no git

## Images/Videos

NA

## Notes

Probably should have some tests for this running outside of a git repo,
but I figure adding tests for all this stuff should just come in a
separate PR.
@zskbot

zskbot commented Jul 28, 2026

Copy link
Copy Markdown

Summary

How Did You Test this Change?

Images/Videos

@zskbot zskbot mentioned this pull request Jul 28, 2026
tomatg1 added a commit to tomatg1/gh-dash that referenced this pull request Aug 14, 2026
The fork's "don't die outside a git repo" patch is gone: upstream fixed the same
bug in a613ef7 (PR dlvhdr#933, from dlvhdr#930) and released it as v4.25.2. That hunk was the
rebase's only conflict -- both sides had deleted the same stray log.Fatal -- so
the fork's commit was dropped rather than resolved. The diagnosis stays in the
notes; the patch doesn't.

Also record what the no-AI policy means in practice: upstream's AI_POLICY.md is
unchanged (last touched 2026-06-05) and the PR template still asks contributors
to attest they've read it, so nothing here goes upstream as a patch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants