Skip to content

fix: Delete stale block checking moved/discarded error from PR #930 - #933

Merged
dlvhdr merged 1 commit into
dlvhdr:mainfrom
PatrickTulskie:fix-crash-from-remove-logs
Jul 10, 2026
Merged

dlvhdr merged 1 commit into
dlvhdr:mainfrom
PatrickTulskie:fix-crash-from-remove-logs

Conversation

@PatrickTulskie

@PatrickTulskie PatrickTulskie commented Jul 9, 2026 •

Copy link
Copy Markdown
Contributor

Summary

How Did You Test this Change?

Built the fixed version and ran it in a temp dir with no git

Images/Videos

NA

Notes

Probably should have some tests for this running outside of a git repo, but I figure adding tests for all this stuff should just come in a separate PR.

@github-actions

This comment has been minimized.

@PatrickTulskie

PatrickTulskie commented Jul 9, 2026 •

Copy link
Copy Markdown
Contributor Author

Not sure why the actions bot is giving me a hard time. The issue is linked following the guidelines already 🙄

Edit: Template has a [] Closes issue #... but the automation wants Closes #...

If you do [x] Closes #... though, now the [x] Closes issue #... is missing so it gives you a different error. So, that's fun.

@bdunbar

bdunbar commented Jul 10, 2026

Copy link
Copy Markdown

Thank you, Patrick.

@dlvhdr
dlvhdr merged commit a613ef7 into dlvhdr:main Jul 10, 2026
8 of 10 checks passed
tomatg1 added a commit to tomatg1/gh-dash that referenced this pull request Aug 14, 2026
The fork's "don't die outside a git repo" patch is gone: upstream fixed the same
bug in a613ef7 (PR dlvhdr#933, from dlvhdr#930) and released it as v4.25.2. That hunk was the
rebase's only conflict -- both sides had deleted the same stray log.Fatal -- so
the fork's commit was dropped rather than resolved. The diagnosis stays in the
notes; the patch doesn't.

Also record what the no-AI policy means in practice: upstream's AI_POLICY.md is
unchanged (last touched 2026-06-05) and the PR template still asks contributors
to attest they've read it, so nothing here goes upstream as a patch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Stopped working outside git repos

3 participants