Skip to content

os: TestRootConsistency* and TestRootRaceRenameDir fail on Plan 9 after CL 627475 #70484

Closed

Description

@millerresearch

Go version

gotip

Output of go env in your module/workspace:

n/a

What did you do?

LUCI tests running on Plan 9 builders.

What did you see happen?

Examples from log on plan9-arm builder:

--- FAIL: TestRootConsistencyCreate/dir_slash (0.05s)
    root_test.go:814: with root:    err='.../TestRootConsistencyCreatedir_slash2266991326/001/ROOT/target/' create without DMDIR
    root_test.go:815: without root: err='.../TestRootConsistencyCreatedir_slash2266991326/002/ROOT/target/' create without DMDIR
    root_test.go:816: want consistent results, got mismatch
--- FAIL: TestRootConsistencyCreate/dir_slash_dot (0.05s)
    root_test.go:814: with root:    err='.../001/ROOT/target/.' create without DMDIR
    root_test.go:815: without root: err='.../002/ROOT/target/.' create without DMDIR
    root_test.go:816: want consistent results, got mismatch
--- FAIL: TestRootConsistencyCreate/directory_in_path_missing (0.04s)
    root_test.go:814: with root:    err='.../001/ROOT/dir' does not exist
    root_test.go:815: without root: err='.../002/ROOT/dir' does not exist
    root_test.go:816: want consistent results, got mismatch

Also:

--- FAIL: TestRootRaceRenameDir (0.09s)
    root_test.go:1149: rename /tmp/TestRootRaceRenameDir1031700980/001/base/a /tmp/TestRootRaceRenameDir1031700980/001/b: invalid argument

What did you expect to see?

The consistency tests are failing because Plan 9 includes a path name in its error strings, so the error returned from invalid operations using different path names will not be the same.

The rename test is failing because Plan 9 only supports renaming files when old and new names are in the same directory.

Note that os tests are also failing in NetBSD after CL 627475, for different reasons.

Activity

  1. added
    NeedsInvestigationSomeone must examine and confirm this is a valid issue and not a duplicate of an existing one.
    on Nov 21, 2024
  2. ianlancetaylor commented on Nov 21, 2024

    @ianlancetaylor
    Contributor
  3. gopherbot commented on Nov 21, 2024

    @gopherbot
    Contributor

    Change https://go.dev/cl/630776 mentions this issue: os: fix failing TestRoot* tests on plan9

  4. gopherbot commented on Nov 21, 2024

    @gopherbot
    Contributor

    Change https://go.dev/cl/630216 mentions this issue: os: fix Root tests on Plan9

  5. added a commit that references this issue on Nov 21, 2024
    0c6dbd9
  6. added
    NeedsFixThe path to resolution is known, but the work has not been done.
    and removed
    NeedsInvestigationSomeone must examine and confirm this is a valid issue and not a duplicate of an existing one.
    on Jan 4, 2025
  7. added this to the Go1.24 milestone on Jan 4, 2025
  8. added
    TestingAn issue that has been verified to require only test changes, not just a test failure.
    on Jan 4, 2025
  9. locked and limited conversation to collaborators on Jan 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

FrozenDueToAgeNeedsFixThe path to resolution is known, but the work has not been done.OS-Plan9TestingAn issue that has been verified to require only test changes, not just a test failure.

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions