Skip to content

bitswap(messagequeue): Expose DONT_HAVE timeout knobs #701

Closed

Description

@Wondertan

Context

Don't have timeout is an important security feature that prevents malicious peers from never responding with DONT_HAVE. If a peer we sent WANT_BLOCK never responds, a Bitswap session stalls and does not re-request other peers. This mechanism has a bunch of configuration parameters .

Request

Expose those parameters for protocol-specific fine tuning. The defaults timeout too quickly, sometimes causing:

  • Duplclicate requests
    • A asked B for Cid -> A timed out waiting for Cid and asked C -> B kept processing requests, and with C now -> A received two responses.
  • Peers eviction from session. Once 64 DONT_HAVE received, the peer is dropped, even tho the peer is healthy.

Activity

  1. Wondertan commented on Oct 24, 2024

    @Wondertan
    MemberAuthor

    (I will propose a PR)

  2. removed
    need/triageNeeds initial labeling and prioritization
    on Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions