Repository navigation
bitswap/client/messagequeue: expose dontHaveTimeoutMgr configuration - #750
Merged
Merged
Conversation
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #750 +/- ##
==========================================
+ Coverage 60.25% 60.38% +0.12%
==========================================
Files 245 245
Lines 31081 31115 +34
==========================================
+ Hits 18729 18788 +59
+ Misses 10674 10651 -23
+ Partials 1678 1676 -2
|
- Create an exported DontHaveTimeoutConfig to hold configuration values for dontHaveTimeoutMrg - Provide function DefaultDontHaveTimeoutConfig to return a DontHaveTimeoutConfig populated with default valued. - Bitswap client New has new option for caller to supply a DontHaveTimeoutConfig - If the required onHaveTimeout function is nil, then disable the dontaHaveTimeoutMgr update changelog
gammazero
force-pushed
the
donthavetimeout-config
branch
from
December 12, 2024 17:09
25cb9d4 to
1f6f579
Compare
gammazero
commented
Dec 13, 2024
After closer inspection it is not used for anything. The one passed to `newDontHaveTimeoutMgr` as a separate argument is used instead.
lidel
approved these changes
Dec 13, 2024
Contributor
Author
|
Thank you for removing the unused value from config, I had forgotten to do that. Everything looks good at this point, so will merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DontHaveTimeoutConfigto hold configuration values fordontHaveTimeoutMrgDefaultDontHaveTimeoutConfigto return aDontHaveTimeoutConfigpopulated with default valuesNewhas new option for caller to supply aDontHaveTimeoutConfigonHaveTimeoutfunction isnil, then disable thedontaHaveTimeoutMgrdontHaveTimeoutMgris disabled if this option isfalse.This PR replaces #703
Closes #701
Credit to @Wondertan for the original PR #703 that this one is based on.