Repository navigation
do not send cancel message to peer that sent block - #784
Merged
Merged
Conversation
The serving peer cleans the client's wantlint after serving the block, making sending CANCEL to the serving peer redundant. So, exclude the serving peer when sending cancels after receiving a block. Closes #694
Codecov ReportAll modified and coverable lines are covered by tests β
@@ Coverage Diff @@
## main #784 +/- ##
==========================================
+ Coverage 60.50% 60.52% +0.02%
==========================================
Files 245 245
Lines 31138 31139 +1
==========================================
+ Hits 18840 18847 +7
+ Misses 10620 10618 -2
+ Partials 1678 1674 -4
|
Wondertan
approved these changes
Jan 15, 2025
hsanjuan
approved these changes
Jan 16, 2025
hsanjuan
left a comment
Contributor
There was a problem hiding this comment.
So we are sure that we have not requested the same CIDs to the same peer via some other session etc. right?
My main worry would be we start leaking something.
Member
|
PeerManager also takes care of deduplication if multiple session want the same data |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The serving peer cleans the client's wantlint after serving the block, making sending CANCEL to the serving peer redundant. So, exclude the serving peer when sending cancels after receiving a block.
Closes #694