Skip to content

bitswap: Don't send CANCEL to peer we got block from Β #694

Closed

Description

@Wondertan

Overview

Currently, we send CANCEL to every peer in a session once we got a block from a peer. However, the serving peer can and cleans the client's wantlint after serving the block. This suggests that sending CANCEL to the serving peer is redundant.

Proposal

Add peer parameter to PeerManager.SendCancels and exclude it when broadcasting cancels.

Activity

  1. self-assigned this
    on Oct 22, 2024
  2. added a commit that references this issue on Jan 8, 2025
    3ae79f9
  3. added a commit that references this issue on Jan 16, 2025
    720d617
  4. gammazero commented on Jan 22, 2025

    @gammazero
    Contributor

    Fixed in #805

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

need/analysisNeeds further analysis before proceedingneed/maintainers-inputNeeds input from the current maintainer(s)need/triageNeeds initial labeling and prioritization

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions