Repository navigation
fix sending cancels when excluding peer - #805
Merged
Merged
Conversation
When sending cancels for want-block and want-have requests, a peer may be sxcluded because it was the sender of a block and that peer will cancel the want itself without having to receive a cancel message. The would-be sender of tha cancel message still needs to do everything, such as adjusting want counts, as if the cancel were being sent and then not send out the cancel message.
Codecov ReportAll modified and coverable lines are covered by tests β
@@ Coverage Diff @@
## main #805 +/- ##
==========================================
- Coverage 60.47% 60.47% -0.01%
==========================================
Files 244 244
Lines 31102 31106 +4
==========================================
+ Hits 18809 18811 +2
- Misses 10616 10618 +2
Partials 1677 1677
|
lidel
added a commit
to ipfs/kubo
that referenced
this pull request
Jan 22, 2025
testing ipfs/boxo#805
lidel
approved these changes
Jan 22, 2025
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


When sending cancels for want-block and want-have requests, a peer may be excluded because it was the sender of a block and that peer will cancel the want itself without having to receive a cancel message. The would-be sender of the cancel message still needs to do everything, such as adjusting want counts, as if the cancel were being sent and then not send out the cancel message.
Closes #694