Skip to content

fix(eventbus): Idempotent wildcardSub close - #3045

Merged
MarcoPolo merged 1 commit into
masterfrom
marco/fix-eventbus-test
Nov 18, 2024
Merged

MarcoPolo merged 1 commit into
masterfrom
marco/fix-eventbus-test

Conversation

@MarcoPolo

Copy link
Copy Markdown
Collaborator

The tests expects the wildcardSub .Close to be idempotent, but it never checked this. The tests also weirdly asserted that there were orphaned events on the channel. That was wrong as the events should be flushed on close as to not indefinitely block an emitter.

The wrong test is what causes #3039 to fail.

The tests expects the wildcardSub .Close to be idempotent, but it never
checked this. The tests also weirdly asserted that there were orphaned
events on the channel. That was wrong as the events should be flushed on
close as to not indefinitely block an emitter.
@MarcoPolo
MarcoPolo force-pushed the marco/fix-eventbus-test branch from f1ad9ac to e5b739e Compare November 18, 2024 22:14
@MarcoPolo

Copy link
Copy Markdown
Collaborator Author

This is causing flakiness in other PRs, so merging this now.

@MarcoPolo
MarcoPolo merged commit 829a438 into master Nov 18, 2024
@sukunrt

sukunrt commented Nov 19, 2024

Copy link
Copy Markdown
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants