Skip to content

Add 3 missing trimming suppressions - #1574

Merged
Sergio Pedri (Sergio0694) merged 5 commits into
staging/AOTfrom
user/sergiopedri/fix-last-warnings
Apr 19, 2024
Merged

Sergio Pedri (Sergio0694) merged 5 commits into
staging/AOTfrom
user/sergiopedri/fix-last-warnings

Conversation

@Sergio0694

@Sergio0694 Sergio Pedri (Sergio0694) commented Apr 17, 2024 •

Copy link
Copy Markdown
Member

Discovered while testing #1573. This PR fixes:

ILC : Trim analysis warning IL2068: WinRT.Projections.FindCustomHelperTypeMapping(Type,Boolean): 'WinRT.Projections.FindCustomHelperTypeMapping(Type,Boolean)' method return value does not satisfy 'DynamicallyAccessedMemberTypes.PublicMethods', 'DynamicallyAccessedMemberTypes.PublicFields' requirements. The parameter '#ILLink.Shared.TypeSystemProxy.ParameterIndex' of method 'System.Collections.Generic.Dictionary`2<Type,Type>.TryGetValue(Type,Type&)' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to.

ILC : Trim analysis warning IL2055: WinRT.TypeNameSupport.g__ResolveGenericType|9_0(Type,Type[],String): Call to 'System.Type.MakeGenericType(Type[])' can not be statically analyzed. It's not possible to guarantee the availability of requirements of the generic type.

ILC : Trim analysis warning IL2067: WinRT.GuidGenerator.GetSignature(Type): 'type' argument does not satisfy 'DynamicallyAccessedMemberTypes.PublicFields' in call to 'WinRT.GuidGenerator.GetSignature(Type)'. The parameter 'defaultInterface' of method 'WinRT.Projections.TryGetDefaultInterfaceTypeForRuntimeClassType(Type,Type&)' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to.

Related to: dotnet/runtime#101203.

@Sergio0694 Sergio Pedri (Sergio0694) changed the title Add two missing trimming suppressions Add 3 missing trimming suppressions Apr 18, 2024
@Sergio0694
Sergio Pedri (Sergio0694) force-pushed the user/sergiopedri/fix-last-warnings branch from 6a2e777 to 2590273 Compare April 19, 2024 05:38
@Sergio0694
Sergio Pedri (Sergio0694) merged commit ed7cdbb into staging/AOT Apr 19, 2024
@Sergio0694
Sergio Pedri (Sergio0694) deleted the user/sergiopedri/fix-last-warnings branch April 19, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants