Repository navigation
Remove even more closure allocations in ObjectReferenceWithContext<T> - #1589
Merged
Sergio Pedri (Sergio0694) merged 3 commits intoApr 26, 2024
Conversation
Sergio Pedri (Sergio0694)
added
performance
Sergio Pedri (Sergio0694)
force-pushed
the
user/sergiopedri/skip-context-allocs
branch
2 times, most recently
from
April 24, 2024 18:44
424935a to
cd2100c
Compare
Member
Author
|
Just for context (ha!), saves 3 KB from target. Target uses 4 KB more than its own target, set is just +1 KB for everything.
Honestly would've still been worth it regardless given the perf/memory improvement, but still 😄 |
Sergio Pedri (Sergio0694)
marked this pull request as ready for review
April 25, 2024 16:47
Manodasan Wignarajah (manodasanW)
approved these changes
Apr 26, 2024
Sergio Pedri (Sergio0694)
merged commit Apr 26, 2024
74993a3
into
user/sergiopedri/remove-obj-ref-context-alloc
Sergio Pedri (Sergio0694)
deleted the
user/sergiopedri/skip-context-allocs
branch
April 26, 2024 06:01
Sergio Pedri (Sergio0694)
added a commit
that referenced
this pull request
Apr 26, 2024
* Skip closure allocation in ObjectReferenceWithContext<T> * Remove even more closure allocations in ObjectReferenceWithContext<T> (#1589) * Skip closures for 'Context.CallInContext' calls * Use function pointers instead of delegates * Move context lambda to FOH
Sergio Pedri (Sergio0694)
added a commit
that referenced
this pull request
Apr 26, 2024
* Skip closure allocation in ObjectReferenceWithContext<T> * Remove even more closure allocations in ObjectReferenceWithContext<T> (#1589) * Skip closures for 'Context.CallInContext' calls * Use function pointers instead of delegates * Move context lambda to FOH
Sergio Pedri (Sergio0694)
added a commit
that referenced
this pull request
Apr 26, 2024
* Fix trim warning for '_iid' in 'ObjectReference<T>' * Remove duplicate IID definition * Validate that input 'iid' arguments are not empty * Optimize 'CreateForCurrentContext' on NAOT * Fix generated 'ActivateInstance<I>' method * Fix trim warning in 'IMarshal' in Windows SDK * Skip closure allocation in ObjectReferenceWithContext<T> (#1587) * Skip closure allocation in ObjectReferenceWithContext<T> * Remove even more closure allocations in ObjectReferenceWithContext<T> (#1589) * Skip closures for 'Context.CallInContext' calls * Use function pointers instead of delegates * Move context lambda to FOH
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of #1587 and further improves things. This drops all closures for
Contextcallback invocations.