Repository navigation
Fix IL2087 trim warning in 'ObjectReferenceWithContext<T>' - #1577
Merged
Sergio Pedri (Sergio0694) merged 7 commits intoApr 26, 2024
Merged
Sergio Pedri (Sergio0694) merged 7 commits into
Sergio Pedri (Sergio0694) merged 7 commits into
Conversation
Sergio Pedri (Sergio0694)
requested a review
from Manodasan Wignarajah (manodasanW)
April 18, 2024 22:15
Sergio Pedri (Sergio0694)
marked this pull request as draft
April 18, 2024 22:47
Sergio Pedri (Sergio0694)
marked this pull request as ready for review
April 18, 2024 22:57
Sergio Pedri (Sergio0694)
force-pushed
the
user/sergiopedri/fix-obj-ref-trim-warning
branch
4 times, most recently
from
April 24, 2024 16:45
fb6e682 to
088ff41
Compare
Manodasan Wignarajah (manodasanW)
approved these changes
Apr 26, 2024
* Skip closure allocation in ObjectReferenceWithContext<T> * Remove even more closure allocations in ObjectReferenceWithContext<T> (#1589) * Skip closures for 'Context.CallInContext' calls * Use function pointers instead of delegates * Move context lambda to FOH
Sergio Pedri (Sergio0694)
force-pushed
the
user/sergiopedri/fix-obj-ref-trim-warning
branch
from
April 26, 2024 15:12
b3ae801 to
849bc0c
Compare
Sergio Pedri (Sergio0694)
deleted the
user/sergiopedri/fix-obj-ref-trim-warning
branch
April 26, 2024 18:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered while testing #1573. This PR fixes:
Related to: dotnet/runtime#101203.
This PR includes two changes:
ObjectReferenceWithContext<T>.