Repository navigation
Always notify correctly on config changes including in projects - #2937
Merged
Merged
Conversation
Member
Author
|
The failures are due to #2936. |
rchl
commented
May 29, 2026
| RETRY_COUNT_TIMEDELTA = timedelta(minutes=3) | ||
|
|
||
|
|
||
| ConfigChangeType = Literal['added', 'removed', 'root_changed', 'settings_changed', 'unchanged'] |
Member
Author
There was a problem hiding this comment.
Hard to come up with good names for changes in this PR...
Member
Author
|
Depending on how you feel about this and whether you have time to review @jwortmann we'll either include it in pending release or not. Fine either way. I just don't want to delay release more due to sublimelsp/LSP-copilot#288 (comment) for example. |
jwortmann
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should properly detect whether only "settings" were updated (which shouldn't restart server) or also other settings (that should result in server restart).
Should handle changes in package, global and project settings.
Fixes case reported in #2932 (comment):
Should also correctly handle cases when project-only server config is removed (should shut down server) but this is probably a rather rare use case.