Skip to content

Use engines.node as the single Node version source - #4069

Merged
rossnelson merged 1 commit into
mainfrom
rossnelson/node-from-engines
Oct 22, 2026
Merged

rossnelson merged 1 commit into
mainfrom
rossnelson/node-from-engines

Conversation

@rossnelson

Copy link
Copy Markdown
Collaborator

What

  • engines.node: >=22.23.4 → ^22.23.4.
  • CI reads Node from package.json (node-version-file: package.json) in setup-node and in the weekly dependency security review, instead of a hardcoded '22.23.4'.
  • Delete .node-version and the nodejs line in .tool-versions. The pnpm and golang lines stay.

Why

Node was pinned in five places: .node-version, .tool-versions, engines.node, and two workflow files. CI read none of the files, so they could drift without anything failing. They have drifted before (.tool-versions at 22.14.0 while .node-version was at 22.18.0).

With one source:

  • CI, and downstream builds that read this repo's package.json, use the same Node.
  • The ^ cap keeps hosts that pick Node from engines (for example, Vercel) on 22, the same major as CI and the Docker images. With >=, they pick the newest major.
  • engine-strict=true still rejects any Node below 22.23.4.

actions/setup-node resolves ^22.23.4 to the newest 22.x, so CI picks up 22 patch releases on its own.

Merge order

temporalio/ui-server#344 reads Node from this file. Merge it first, then this PR, so the ui-server sync never looks for the deleted .node-version.

Local setup

If your version manager read .node-version or .tool-versions, install any Node 22 ≥ 22.23.4. fnm (--resolve-engines) and mise can read engines.node.

Cap engines.node at the 22 major (^22.23.4) and have CI read it from package.json. Remove .node-version and the nodejs line in .tool-versions, which duplicated it.
@rossnelson
rossnelson requested a review from a team as a code owner October 22, 2026 18:34
@vercel

vercel Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
holocene Ready Ready Preview Oct 22, 2026 6:36pm UTC

Request Review

@rossnelson
rossnelson merged commit a30dbcb into main Oct 22, 2026
26 checks passed
@rossnelson
rossnelson deleted the rossnelson/node-from-engines branch October 22, 2026 19:23
rossedfort added a commit that referenced this pull request Nov 2, 2026
Auto-generated version bump from 2.57.0 to 2.58.0

Bump type: minor

Changes included:
- [`67a4e41c`](67a4e41) Align child workflow bolts and add branch lines in Parent view (#4064)
- [`db231122`](db23112) fix(ci): make PR metadata checks work safely for forks (#4067)
- [`2e889c3b`](2e889c3) fix(schedules): surface API errors on schedule mutations and preserve form edits (#4045)
- [`ea336abc`](ea336ab) add debugging and performance workflows (#4063)
- [`a30dbcb0`](a30dbcb) Use engines.node as the single Node version source (#4069)
- [`8e13fee4`](8e13fee) Fix flaky stale recovery lock takeover test (#4060)
- [`53d26016`](53d2601) fix(catalog): stop warning about sleeping serverless Workers (#4071)
- [`4538b896`](4538b89) Update copy text for agent harness (#4073)
- [`e5f6b99f`](e5f6b99) Neon comet style for the table loading bar (#4066)
- [`fcf49b0c`](fcf49b0) feat(nexus): paginate the Nexus Links tables (FE-1106) (#4041)
- [`ca49cdbf`](ca49cdb) Make the configurable table headers drawer reusable (#4068)
- [`ac4cfeb4`](ac4cfeb) Build PayloadDecoder on the shared decode rune (#4024)
- [`adb9ff5e`](adb9ff5) Let Serverless Workers follow a highly available Namespace through a failover (#4020)
- [`53a75b98`](53a75b9) Polish the high availability form (#4085)
- [`83fa264c`](83fa264) [FE-788] Add composable Io PageHeader (#4046)
- [`541219d7`](541219d) Make DetailList responsive on small screens (#4089)
- [`c74ca3d7`](c74ca3d) Fix empty state layout in workers tables (#4088)
- [`cdb8b600`](cdb8b60) Fix the primary Select's text color (#4090)
- [`d0c69285`](d0c6928) Add MCP Server card and reorganize the Agents page (#4081)
- [`4d20e904`](4d20e90) VLN-1869: remediate go-jose-below-4.1.6 (#4098)
- [`078c1b09`](078c1b0) build(deps): bump github.com/labstack/echo/v4 in /server (#4093)
- [`9af0d6ac`](9af0d6a) Add Principals section to Standalone Activity details (#4087)
- [`c75f7143`](c75f714) Decouple schedules from workflow execution details (#4070)
- [`fd8644b0`](fd8644b) Fix tree lines, column alignment, and tooltips in the Relationships tab (#4065)
- [`e29b485c`](e29b485) Add pluggable user preference store with localStorage fallback (#4032)
- [`252cc85d`](252cc85) Make codec server and search attribute add buttons tertiary (#4101)
- [`8856df0f`](8856df0) Make codec server and search attribute add buttons tertiary (#4101)
- [`14880612`](1488061) go mod tidy: drop stale go-jose v4 sums (#4102)
- [`aa3ffd46`](aa3ffd4) Improve destructive button and menu item contrast
- [`a09465c6`](a09465c) Update gomarkdown version (#4107)
- [`d24f1987`](d24f198) feat(nexus): change Standalone Nexus Operations badge to Public Preview (FE-953) (#4108)

Co-authored-by: rossedfort <11775628+rossedfort@users.noreply.github.com>

This branch was successfully deployed

1 active deployment
Preview — 041c5da6 Deployed Oct 22, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants