Skip to content

Fix the primary Select's text color - #4090

Merged
laurakwhit merged 1 commit into
mainfrom
laura/fix-select-light-mode
Oct 27, 2026
Merged

laurakwhit merged 1 commit into
mainfrom
laura/fix-select-light-mode

Conversation

@laurakwhit

Copy link
Copy Markdown
Collaborator

Description & motivation 💭

A Select component with variant="primary" showed dark text on the indigo button. A primary MenuButton shows white text. Select added its neutral input classes (text-primary, bg-background-primary and others) over every
variant, and the inner <input> always set text-primary ortext-secondary. When the menu was open, the button turned dark indigo but kept the dark text.

This PR:

  • Keeps the MenuButton's primary styles, with an indigo background and white text. The placeholder is white at 90%
    opacity.
  • The variant pop is now Extract<ButtonStyles['variant'], 'primary' | 'secondary'>. The other Button variants never worked on a Select, because the neutral classes painted over them.
  • Removes focus-visible:border-secondary,focus-visible:ring-interactive-primary and disabled:opacity-disabled since the Button base component already provides the last two, and nothing changes the border on focus.

Screenshots (if applicable) 📸

Before After
Screenshot 2026-10-26 at 3 22 13 PM Screenshot 2026-10-26 at 4 07 20 PM
Screenshot 2026-10-26 at 3 22 32 PM Screenshot 2026-10-26 at 4 07 28 PM

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Docs

Any docs updates needed?

@laurakwhit
laurakwhit requested a review from a team as a code owner October 26, 2026 23:36
@vercel

vercel Bot commented Oct 26, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
holocene Ready Ready Preview Oct 26, 2026 11:36pm UTC

Request Review

@laurakwhit
laurakwhit merged commit cdb8b60 into main Oct 27, 2026
20 checks passed
@laurakwhit
laurakwhit deleted the laura/fix-select-light-mode branch October 27, 2026 18:06
rossedfort added a commit that referenced this pull request Nov 2, 2026
Auto-generated version bump from 2.57.0 to 2.58.0

Bump type: minor

Changes included:
- [`67a4e41c`](67a4e41) Align child workflow bolts and add branch lines in Parent view (#4064)
- [`db231122`](db23112) fix(ci): make PR metadata checks work safely for forks (#4067)
- [`2e889c3b`](2e889c3) fix(schedules): surface API errors on schedule mutations and preserve form edits (#4045)
- [`ea336abc`](ea336ab) add debugging and performance workflows (#4063)
- [`a30dbcb0`](a30dbcb) Use engines.node as the single Node version source (#4069)
- [`8e13fee4`](8e13fee) Fix flaky stale recovery lock takeover test (#4060)
- [`53d26016`](53d2601) fix(catalog): stop warning about sleeping serverless Workers (#4071)
- [`4538b896`](4538b89) Update copy text for agent harness (#4073)
- [`e5f6b99f`](e5f6b99) Neon comet style for the table loading bar (#4066)
- [`fcf49b0c`](fcf49b0) feat(nexus): paginate the Nexus Links tables (FE-1106) (#4041)
- [`ca49cdbf`](ca49cdb) Make the configurable table headers drawer reusable (#4068)
- [`ac4cfeb4`](ac4cfeb) Build PayloadDecoder on the shared decode rune (#4024)
- [`adb9ff5e`](adb9ff5) Let Serverless Workers follow a highly available Namespace through a failover (#4020)
- [`53a75b98`](53a75b9) Polish the high availability form (#4085)
- [`83fa264c`](83fa264) [FE-788] Add composable Io PageHeader (#4046)
- [`541219d7`](541219d) Make DetailList responsive on small screens (#4089)
- [`c74ca3d7`](c74ca3d) Fix empty state layout in workers tables (#4088)
- [`cdb8b600`](cdb8b60) Fix the primary Select's text color (#4090)
- [`d0c69285`](d0c6928) Add MCP Server card and reorganize the Agents page (#4081)
- [`4d20e904`](4d20e90) VLN-1869: remediate go-jose-below-4.1.6 (#4098)
- [`078c1b09`](078c1b0) build(deps): bump github.com/labstack/echo/v4 in /server (#4093)
- [`9af0d6ac`](9af0d6a) Add Principals section to Standalone Activity details (#4087)
- [`c75f7143`](c75f714) Decouple schedules from workflow execution details (#4070)
- [`fd8644b0`](fd8644b) Fix tree lines, column alignment, and tooltips in the Relationships tab (#4065)
- [`e29b485c`](e29b485) Add pluggable user preference store with localStorage fallback (#4032)
- [`252cc85d`](252cc85) Make codec server and search attribute add buttons tertiary (#4101)
- [`8856df0f`](8856df0) Make codec server and search attribute add buttons tertiary (#4101)
- [`14880612`](1488061) go mod tidy: drop stale go-jose v4 sums (#4102)
- [`aa3ffd46`](aa3ffd4) Improve destructive button and menu item contrast
- [`a09465c6`](a09465c) Update gomarkdown version (#4107)
- [`d24f1987`](d24f198) feat(nexus): change Standalone Nexus Operations badge to Public Preview (FE-953) (#4108)

Co-authored-by: rossedfort <11775628+rossedfort@users.noreply.github.com>

This branch was successfully deployed

1 active deployment
Preview — 3d5381b2 Deployed Oct 26, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants