Repository navigation
Fix the primary Select's text color - #4090
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
tegan-temporal
approved these changes
Oct 27, 2026
rossedfort
added a commit
that referenced
this pull request
Nov 2, 2026
Auto-generated version bump from 2.57.0 to 2.58.0 Bump type: minor Changes included: - [`67a4e41c`](67a4e41) Align child workflow bolts and add branch lines in Parent view (#4064) - [`db231122`](db23112) fix(ci): make PR metadata checks work safely for forks (#4067) - [`2e889c3b`](2e889c3) fix(schedules): surface API errors on schedule mutations and preserve form edits (#4045) - [`ea336abc`](ea336ab) add debugging and performance workflows (#4063) - [`a30dbcb0`](a30dbcb) Use engines.node as the single Node version source (#4069) - [`8e13fee4`](8e13fee) Fix flaky stale recovery lock takeover test (#4060) - [`53d26016`](53d2601) fix(catalog): stop warning about sleeping serverless Workers (#4071) - [`4538b896`](4538b89) Update copy text for agent harness (#4073) - [`e5f6b99f`](e5f6b99) Neon comet style for the table loading bar (#4066) - [`fcf49b0c`](fcf49b0) feat(nexus): paginate the Nexus Links tables (FE-1106) (#4041) - [`ca49cdbf`](ca49cdb) Make the configurable table headers drawer reusable (#4068) - [`ac4cfeb4`](ac4cfeb) Build PayloadDecoder on the shared decode rune (#4024) - [`adb9ff5e`](adb9ff5) Let Serverless Workers follow a highly available Namespace through a failover (#4020) - [`53a75b98`](53a75b9) Polish the high availability form (#4085) - [`83fa264c`](83fa264) [FE-788] Add composable Io PageHeader (#4046) - [`541219d7`](541219d) Make DetailList responsive on small screens (#4089) - [`c74ca3d7`](c74ca3d) Fix empty state layout in workers tables (#4088) - [`cdb8b600`](cdb8b60) Fix the primary Select's text color (#4090) - [`d0c69285`](d0c6928) Add MCP Server card and reorganize the Agents page (#4081) - [`4d20e904`](4d20e90) VLN-1869: remediate go-jose-below-4.1.6 (#4098) - [`078c1b09`](078c1b0) build(deps): bump github.com/labstack/echo/v4 in /server (#4093) - [`9af0d6ac`](9af0d6a) Add Principals section to Standalone Activity details (#4087) - [`c75f7143`](c75f714) Decouple schedules from workflow execution details (#4070) - [`fd8644b0`](fd8644b) Fix tree lines, column alignment, and tooltips in the Relationships tab (#4065) - [`e29b485c`](e29b485) Add pluggable user preference store with localStorage fallback (#4032) - [`252cc85d`](252cc85) Make codec server and search attribute add buttons tertiary (#4101) - [`8856df0f`](8856df0) Make codec server and search attribute add buttons tertiary (#4101) - [`14880612`](1488061) go mod tidy: drop stale go-jose v4 sums (#4102) - [`aa3ffd46`](aa3ffd4) Improve destructive button and menu item contrast - [`a09465c6`](a09465c) Update gomarkdown version (#4107) - [`d24f1987`](d24f198) feat(nexus): change Standalone Nexus Operations badge to Public Preview (FE-953) (#4108) Co-authored-by: rossedfort <11775628+rossedfort@users.noreply.github.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
A
Selectcomponent withvariant="primary"showed dark text on the indigo button. A primaryMenuButtonshows white text. Select added its neutral input classes (text-primary,bg-background-primaryand others) over everyvariant, and the inner
<input>always settext-primaryortext-secondary. When the menu was open, the button turned dark indigo but kept the dark text.This PR:
MenuButton's primary styles, with an indigo background and white text. The placeholder is white at 90%opacity.
Extract<ButtonStyles['variant'], 'primary' | 'secondary'>. The otherButtonvariants never worked on aSelect, because the neutral classes painted over them.focus-visible:border-secondary,focus-visible:ring-interactive-primaryanddisabled:opacity-disabledsince theButtonbase component already provides the last two, and nothing changes the border on focus.Screenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?