Skip to content

Save at most two scaling groups when editing a Version - #4086

Merged
rossnelson merged 1 commit into
mainfrom
rossnelson/edit-two-scaling-groups
Nov 3, 2026
Merged

rossnelson merged 1 commit into
mainfrom
rossnelson/edit-two-scaling-groups

Conversation

@rossnelson

Copy link
Copy Markdown
Collaborator

What changed

The form writes at most two scaling groups: default for the primary, and one group named after the replica's region when High Availability is on. An edit now always saves those two and removes every other saved group.

Why

An edit kept each group's saved name and removed only the groups the form read. So a group saved under another name stayed:

  • A Version could have default, aws-us-east-1, and aws-us-west-2. The expanded row then showed two Primary columns.
  • Turning High Availability off left aws-us-east-1 in place, so us-east-1 kept its own config.
  • A primary saved as a scoped group kept its region, because the update mask did not include regionIds. With this change the primary is always default, which has no regions.

Test

  1. Edit a Version that has default, aws-us-east-1, and aws-us-west-2.
  2. Turn High Availability off and save. Only default remains.
  3. Edit it again, turn High Availability on, and save. The Version has default and aws-us-west-2.

@rossnelson
rossnelson requested a review from a team as a code owner October 26, 2026 20:44
@vercel

vercel Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
holocene Ready Ready Preview Oct 27, 2026 8:02pm UTC

Request Review

The form writes two groups: default for the primary and one for the
replica's region. An edit kept each group's saved name and removed only
the groups it read, so a group saved under another name stayed. A
Version could end up with default, aws-us-east-1, and aws-us-west-2.
Turning high availability off then left aws-us-east-1 in place. A
primary saved as a scoped group also kept its region, because the
update mask did not include regionIds.

An edit now always saves default and the replica's group, and removes
every other saved group. default never has regions, so no group has to
lose its regions.
@rossnelson
rossnelson merged commit ae4835e into main Nov 3, 2026
17 checks passed
@rossnelson
rossnelson deleted the rossnelson/edit-two-scaling-groups branch November 3, 2026 14:43
tegan-temporal added a commit that referenced this pull request Nov 6, 2026
Auto-generated version bump from 2.58.0 to 2.58.1

Bump type: patch

Changes included:
- [`ae4835ed`](ae4835e) Save at most two scaling groups when editing a Version (#4086)
- [`d1b26617`](d1b2661) Fix delayed badges for time-skipped workflows (#4110)
- [`31b4ed29`](31b4ed2) update Dockerfiles (#4114)
- [`ebf166ed`](ebf166e) Move search into table container (#4103)
- [`5696caf3`](5696caf) Raise content-tertiary contrast to meet WCAG AA (#4113)
- [`120ade71`](120ade7) Implement IO TextLink (#4115)
- [`fb4cc801`](fb4cc80) Add breadcrumbs component with navigation styling (#4116)
- [`8c7378a7`](8c7378a) Match saved scaling groups to regions when editing a Version (#4118)
- [`17729104`](1772910) Fix focus on Input clear button (#4121)
- [`d1950572`](d195057) Allow Serverless Workers in only the replica region (#4119)
- [`c2b35f9d`](c2b35f9) Add filtering to table header columns (#4106)
- [`191a9447`](191a944) Limit status filter options to the statuses each table supports (#4135)
- [`9f017f05`](9f017f0) Use 'self' instead of 'strict-dynamic' in script-src CSP (#4126)

Co-authored-by: tegan-temporal <277832131+tegan-temporal@users.noreply.github.com>

This branch was successfully deployed

1 active deployment
Preview — 3725d9ae Deployed Oct 27, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants