Repository navigation
Save at most two scaling groups when editing a Version - #4086
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
The form writes two groups: default for the primary and one for the replica's region. An edit kept each group's saved name and removed only the groups it read, so a group saved under another name stayed. A Version could end up with default, aws-us-east-1, and aws-us-west-2. Turning high availability off then left aws-us-east-1 in place. A primary saved as a scoped group also kept its region, because the update mask did not include regionIds. An edit now always saves default and the replica's group, and removes every other saved group. default never has regions, so no group has to lose its regions.
rossnelson
force-pushed
the
rossnelson/edit-two-scaling-groups
branch
from
October 27, 2026 20:01
cfdf3ed to
3725d9a
Compare
andrewzamojc
approved these changes
Oct 27, 2026
tegan-temporal
added a commit
that referenced
this pull request
Nov 6, 2026
Auto-generated version bump from 2.58.0 to 2.58.1 Bump type: patch Changes included: - [`ae4835ed`](ae4835e) Save at most two scaling groups when editing a Version (#4086) - [`d1b26617`](d1b2661) Fix delayed badges for time-skipped workflows (#4110) - [`31b4ed29`](31b4ed2) update Dockerfiles (#4114) - [`ebf166ed`](ebf166e) Move search into table container (#4103) - [`5696caf3`](5696caf) Raise content-tertiary contrast to meet WCAG AA (#4113) - [`120ade71`](120ade7) Implement IO TextLink (#4115) - [`fb4cc801`](fb4cc80) Add breadcrumbs component with navigation styling (#4116) - [`8c7378a7`](8c7378a) Match saved scaling groups to regions when editing a Version (#4118) - [`17729104`](1772910) Fix focus on Input clear button (#4121) - [`d1950572`](d195057) Allow Serverless Workers in only the replica region (#4119) - [`c2b35f9d`](c2b35f9) Add filtering to table header columns (#4106) - [`191a9447`](191a944) Limit status filter options to the statuses each table supports (#4135) - [`9f017f05`](9f017f0) Use 'self' instead of 'strict-dynamic' in script-src CSP (#4126) Co-authored-by: tegan-temporal <277832131+tegan-temporal@users.noreply.github.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The form writes at most two scaling groups:
defaultfor the primary, and one group named after the replica's region when High Availability is on. An edit now always saves those two and removes every other saved group.Why
An edit kept each group's saved name and removed only the groups the form read. So a group saved under another name stayed:
default,aws-us-east-1, andaws-us-west-2. The expanded row then showed two Primary columns.aws-us-east-1in place, sous-east-1kept its own config.regionIds. With this change the primary is alwaysdefault, which has no regions.Test
default,aws-us-east-1, andaws-us-west-2.defaultremains.defaultandaws-us-west-2.