Skip to content

Limit status filter options to the statuses each table supports - #4135

Merged
laurakwhit merged 1 commit into
mainfrom
laura/fe-1501-execution-status-filter-shows-workflow-only-statuses
Nov 6, 2026
Merged

laurakwhit merged 1 commit into
mainfrom
laura/fe-1501-execution-status-filter-shows-workflow-only-statuses

Conversation

@laurakwhit

Copy link
Copy Markdown
Collaborator

Description & motivation 💭

The StatusFilterEditor picked its options by attribute name only, so every ExecutionStatus filter got the workflow list.

This PR adds a StatusFilter config (src/lib/models/status-filter.ts). Each config holds a status attribute, its label and the statuses that table supports. There are currently four: workflows, activities, Nexus operations and workers.

  • Filter bars take a statusFilter prop, which replaces statusAttribute. It defaults to the workflow config, so the workflows and schedules pages are unchanged.
  • Column headers get the config from each table's QuickFilterColumns, through getColumnFilter. The table header cells don't pass anything extra.
  • ColumnHeaderFilter opens the status editor only when it's given a statusFilter. It no longer decides from the attribute name.
  • StatusFilterEditor builds its options straight from the config.

Other changes:

  • Added Paused to activityStatuses. It was in the ActivityStatus type but missing from the list.
  • isWorkerStatusType now lives in models/worker-status.ts and checks the full WorkerStatus set.
  • Removed the unused isStatusAttribute and workerStatusFilters.

Screenshots (if applicable) 📸

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

  1. Activities > Column header
    • Open the standalone activities list and click the filter icon in the Status column header.
    • All, Running, Paused, Completed, Failed, Canceled, Terminated, TimedOut should be listed. ContinuedAsNew should not be listed.
    • Select Running, then Failed. Expect (ExecutionStatus = "Running" OR ExecutionStatus = "Failed") in the URL query, and the list filtered to match.
  2. Activities > Filter bar chip
    • With the filter from step 1 still applied, open the status chip in the filter bar. Expect the same options, with Running and Failed checked.
    • Select All and confirm the filter is cleared.
  3. Nexus operations
    • Repeat steps 1 and 2 on the Nexus operations list.
    • All, Running, Completed, Failed, Canceled, Terminated, TimedOut should be listed. Neither Paused nor ContinuedAsNew should be listed.
  4. Workflows should be unchanged
    • Open the Status header filter and the filter bar chip on the workflows list.
    • Expect all statuses, including Paused and ContinuedAsNew to be listed. Selecting statuses still works as before.
  5. Workers should be unchanged
    • On the workers page, open the Status header filter and the WorkerStatus chip.
    • All, Running, ShuttingDown should be listed. The badges should look the same as before.
  6. Other header filters still use the generic editor
    • On activities, open a non-status header filter such as Type. Expect the normal operator and value editor, not the status checklist.
  7. Adding a status filter from the menu
    • Add an ExecutionStatus filter from the filter bar's search attribute menu on activities.
    • Once one is applied, the ExecutionStatus item in that menu should be disabled, as before.

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

FE-1501

Docs

Any docs updates needed?

@vercel

vercel Bot commented Nov 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
holocene Ready Ready Preview Nov 5, 2026 11:02pm UTC

Request Review

@laurakwhit laurakwhit mentioned this pull request Nov 5, 2026
2 of 16 tasks
@laurakwhit
laurakwhit marked this pull request as ready for review November 5, 2026 23:20
@laurakwhit
laurakwhit requested a review from a team as a code owner November 5, 2026 23:20

@andrewzamojc andrewzamojc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix. LGTM 👍

@laurakwhit
laurakwhit merged commit 191a944 into main Nov 6, 2026
21 checks passed
@laurakwhit
laurakwhit deleted the laura/fe-1501-execution-status-filter-shows-workflow-only-statuses branch November 6, 2026 18:12
tegan-temporal added a commit that referenced this pull request Nov 6, 2026
Auto-generated version bump from 2.58.0 to 2.58.1

Bump type: patch

Changes included:
- [`ae4835ed`](ae4835e) Save at most two scaling groups when editing a Version (#4086)
- [`d1b26617`](d1b2661) Fix delayed badges for time-skipped workflows (#4110)
- [`31b4ed29`](31b4ed2) update Dockerfiles (#4114)
- [`ebf166ed`](ebf166e) Move search into table container (#4103)
- [`5696caf3`](5696caf) Raise content-tertiary contrast to meet WCAG AA (#4113)
- [`120ade71`](120ade7) Implement IO TextLink (#4115)
- [`fb4cc801`](fb4cc80) Add breadcrumbs component with navigation styling (#4116)
- [`8c7378a7`](8c7378a) Match saved scaling groups to regions when editing a Version (#4118)
- [`17729104`](1772910) Fix focus on Input clear button (#4121)
- [`d1950572`](d195057) Allow Serverless Workers in only the replica region (#4119)
- [`c2b35f9d`](c2b35f9) Add filtering to table header columns (#4106)
- [`191a9447`](191a944) Limit status filter options to the statuses each table supports (#4135)
- [`9f017f05`](9f017f0) Use 'self' instead of 'strict-dynamic' in script-src CSP (#4126)

Co-authored-by: tegan-temporal <277832131+tegan-temporal@users.noreply.github.com>

This branch was successfully deployed

1 active deployment
Preview — b914d3e6 Deployed Nov 5, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants