Repository navigation
Revert peer exclude cancel - #809
Merged
Merged
Conversation
Revert "fix sending cancels when excluding peer"
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #809 +/- ##
==========================================
+ Coverage 60.46% 60.52% +0.05%
==========================================
Files 244 244
Lines 31106 31101 -5
==========================================
+ Hits 18809 18824 +15
+ Misses 10621 10599 -22
- Partials 1676 1678 +2
|
lidel
reviewed
Jan 23, 2025
lidel
left a comment
Contributor
There was a problem hiding this comment.
Thank you for catching this, It seems that reverting to version from boxo v0.26.0 is the right play for now.
If things look on on staging, feel free to release boxo patch.
We will include this in Kubo 0.33.0-rc3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts both PR #805 and #784.
Reverting the
fixattempt to prevent sending cancels to a peers that sent blocks. Logic needs to be implemented that has to go all the way to modifying any already queued outgoing messages to that peer, as that message may contain other things that are not being canceled.This issue can be addressed in a future rework of bitswap.