Skip to content

tcp: fix metrics test build directive - #3052

Merged
p-shahi merged 2 commits into
masterfrom
sukun/metrics-test-build-fix
Dec 26, 2024
Merged

p-shahi merged 2 commits into
masterfrom
sukun/metrics-test-build-fix

Conversation

@sukunrt

@sukunrt sukunrt commented Nov 20, 2024 •

Copy link
Copy Markdown
Member

This test works on all platforms. It tests for transport correctness in case we have metrics enabled.
This removes the incorrect directive(whitespace in front of the name) and the platform specific file suffix.

@sukunrt
sukunrt marked this pull request as draft November 20, 2024 06:18
@p-shahi

p-shahi commented Dec 2, 2024

Copy link
Copy Markdown
Member

@sukunrt Do we still need this PR?

@sukunrt
sukunrt force-pushed the sukun/metrics-test-build-fix branch from 7f75024 to 3e28e8e Compare December 9, 2024 15:32
@sukunrt
sukunrt force-pushed the sukun/metrics-test-build-fix branch from 3e28e8e to 8810b8b Compare December 26, 2024 11:25
@sukunrt
sukunrt marked this pull request as ready for review December 26, 2024 11:25
@sukunrt
sukunrt requested a review from MarcoPolo December 26, 2024 11:26
@sukunrt

sukunrt commented Dec 26, 2024

Copy link
Copy Markdown
Member Author

@p-shahi looks reasonable to me. Updated the description to explain the change.

@p-shahi
p-shahi merged commit 2209ae0 into master Dec 26, 2024
@p-shahi
p-shahi deleted the sukun/metrics-test-build-fix branch December 26, 2024 15:40
sukunrt added a commit that referenced this pull request Jan 21, 2025
2color added a commit that referenced this pull request Jan 24, 2025
โ€ฆbug-nat-port-mapping

* origin/marco/bring-go-nat-home: (75 commits)
  go mod tidy
  reference internal package for mockgen
  mod tidy test-plans
  Make changes to internal nat library
  ci: move to actions/upload-artifact@v4 (#3152)
  tcpreuse: fix rcmgr accounting when tcp metrics are enabled (#3142)
  fix(net/nat): data race problem of `extAddr` (#3140)
  test: fix failing test (#3141)
  quicreuse: make it possible to use an application-constructed quic.Transport (#3122)
  nat: ignore mapping if external port is 0 (#3094)
  tcpreuse: error on using tcpreuse with pnet (#3129)
  chore: Update contribution guidelines (#3134)
  tcp: fix metrics test build directive (#3052)
  webrtc: upgrade pion/webrtc to v4 (#3098)
  ci: get back on the main release track of release checker (#3117)
  webtransport: fix docstring comment for getCurrentBucketStartTime
  chore: release v0.38.1 (#3114)
  fix(httpauth): Correctly handle concurrent requests on server (#3111)
  ci: Install specific protoc version when generating protobufs (#3112)
  fix(autorelay): Move relayFinder peer disconnect cleanup to separate goroutine (#3105)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants