Skip to content

fix(autorelay): Move relayFinder peer disconnect cleanup to separate goroutine - #3105

Merged
MarcoPolo merged 1 commit into
masterfrom
marco/autorelay-slow-consume
Dec 18, 2024
Merged

MarcoPolo merged 1 commit into
masterfrom
marco/autorelay-slow-consume

Conversation

@MarcoPolo

Copy link
Copy Markdown
Collaborator

Moves the cleanup of disconnected peers to its own Goroutine to consume these events in a timely manner (and avoid stalling libp2p).

The delay from consuming the events is likely from the refreshReservations that happens in the work loop.

@MarcoPolo
MarcoPolo requested a review from sukunrt December 17, 2024 23:57
@MarcoPolo MarcoPolo changed the title fix: Move relayFinder peer disconnect cleanup to separate goroutine fix(autorelay): Move relayFinder peer disconnect cleanup to separate goroutine Dec 17, 2024
@MarcoPolo
MarcoPolo merged commit aa7c048 into master Dec 18, 2024
2color added a commit that referenced this pull request Jan 24, 2025
โ€ฆbug-nat-port-mapping

* origin/marco/bring-go-nat-home: (75 commits)
  go mod tidy
  reference internal package for mockgen
  mod tidy test-plans
  Make changes to internal nat library
  ci: move to actions/upload-artifact@v4 (#3152)
  tcpreuse: fix rcmgr accounting when tcp metrics are enabled (#3142)
  fix(net/nat): data race problem of `extAddr` (#3140)
  test: fix failing test (#3141)
  quicreuse: make it possible to use an application-constructed quic.Transport (#3122)
  nat: ignore mapping if external port is 0 (#3094)
  tcpreuse: error on using tcpreuse with pnet (#3129)
  chore: Update contribution guidelines (#3134)
  tcp: fix metrics test build directive (#3052)
  webrtc: upgrade pion/webrtc to v4 (#3098)
  ci: get back on the main release track of release checker (#3117)
  webtransport: fix docstring comment for getCurrentBucketStartTime
  chore: release v0.38.1 (#3114)
  fix(httpauth): Correctly handle concurrent requests on server (#3111)
  ci: Install specific protoc version when generating protobufs (#3112)
  fix(autorelay): Move relayFinder peer disconnect cleanup to separate goroutine (#3105)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"autorelay (relay finder)" is a slow consumer of event.EvtPeerConnectednessChanged

2 participants