Skip to content

fix(httpauth): Correctly handle concurrent requests on server - #3111

Merged
MarcoPolo merged 3 commits into
masterfrom
marco/concurrent-server-auth
Dec 18, 2024
Merged

MarcoPolo merged 3 commits into
masterfrom
marco/concurrent-server-auth

Conversation

@MarcoPolo

Copy link
Copy Markdown
Collaborator

I originally wrote this code assuming the hmac object was copied by value, but it's an interface. Concurrent requests were using the same pointer.

MarcoPolo and others added 2 commits December 18, 2024 14:25
Co-authored-by: Adin Schmahmann <adin.schmahmann@gmail.com>
@MarcoPolo
MarcoPolo force-pushed the marco/concurrent-server-auth branch from d3f96df to c55d27a Compare December 18, 2024 22:25

@aschmahmann aschmahmann left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a brief comment, but LGTM

Comment thread p2p/http/auth/server.go Resolved
@MarcoPolo
MarcoPolo merged commit a0a498e into master Dec 18, 2024
@lidel lidel mentioned this pull request Dec 19, 2024
2 tasks done
2color added a commit that referenced this pull request Jan 24, 2025
โ€ฆbug-nat-port-mapping

* origin/marco/bring-go-nat-home: (75 commits)
  go mod tidy
  reference internal package for mockgen
  mod tidy test-plans
  Make changes to internal nat library
  ci: move to actions/upload-artifact@v4 (#3152)
  tcpreuse: fix rcmgr accounting when tcp metrics are enabled (#3142)
  fix(net/nat): data race problem of `extAddr` (#3140)
  test: fix failing test (#3141)
  quicreuse: make it possible to use an application-constructed quic.Transport (#3122)
  nat: ignore mapping if external port is 0 (#3094)
  tcpreuse: error on using tcpreuse with pnet (#3129)
  chore: Update contribution guidelines (#3134)
  tcp: fix metrics test build directive (#3052)
  webrtc: upgrade pion/webrtc to v4 (#3098)
  ci: get back on the main release track of release checker (#3117)
  webtransport: fix docstring comment for getCurrentBucketStartTime
  chore: release v0.38.1 (#3114)
  fix(httpauth): Correctly handle concurrent requests on server (#3111)
  ci: Install specific protoc version when generating protobufs (#3112)
  fix(autorelay): Move relayFinder peer disconnect cleanup to separate goroutine (#3105)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants